Issue 226413006: GTK: Adds #error statements to GTK code to root out unknown bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226413006: GTK: Adds #error statements to GTK code to root out unknown bots. (Closed)

Created:
6 years, 8 months ago by Elliot Glaysher

Modified:
6 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, James Su, sadrul, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTK: Adds #error statements to GTK code to root out unknown bots. BUG=297026 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263054

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -0 lines)			Patch
M	base/message_loop/message_pump_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/gtk/owned_widget_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/path_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/native_theme/native_theme_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/surface/transport_dib_gtk.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

jam: to be committed once your infrastructure patch goes in.

6 years, 8 months ago (2014-04-09 20:31:59 UTC) #1

jam

On 2014/04/09 20:31:59, Elliot Glaysher wrote: > jam: to be committed once your infrastructure patch ...

6 years, 8 months ago (2014-04-09 22:34:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r263054.

Expand Messages | Collapse Messages