Issue 226413005: get iOS building again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226413005: get iOS building again (Closed)

Created:
6 years, 8 months ago by mtklein_C

Modified:
6 years, 8 months ago

Reviewers:
epoger, bsalomon, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

get iOS building again 1) Disable SampleApp. Seems like it's totally horked? SkOSFile_iOS.mm is missing about half the functions needed, and SkOSFile_stdio.cpp is double-providing the others. 2) Drop armv6. 3) Switch from putting headers in sources to putting the corresponding directories in includes. 4) Force cast the type of glShaderSource. Something to do with GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE? After all this, env CC=clang CXX=clang++ GYP_DEFINES=skia_os=ios make builds for me. BUG=skia:2363 Committed: http://code.google.com/p/skia/source/detail?r=14069

Patch Set 1 #

Patch Set 2 : just cast #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -25 lines)			Patch
M	gyp/SampleApp.gyp	View		3 chunks	+2 lines, -12 lines	0 comments	Download
M	gyp/SimpleiOSApp.gyp	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	gyp/apptype_console.gypi	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	gyp/common_conditions.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/most.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

epoger

LGTM I think some bots may still have the problem I described in https://code.google.com/p/skia/issues/detail?id=2363#c7 : ...

6 years, 8 months ago (2014-04-04 23:53:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/226413005/20001

6 years, 8 months ago (2014-04-05 00:56:08 UTC) #4

Message was sent while issue was closed.

Change committed as 14069

Expand Messages | Collapse Messages