Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2264113003: SkPDF: PDFDevice cleanup. (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: PDFDevice cleanup. Remove unused fContentSize. Combine SkPDFDevice::writeContent and SkPDFDevice::content. Remove unused SkPDFDevice::initialTransform(). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264113003 Committed: https://skia.googlesource.com/skia/+/afdc177e77a4d083a23f709113ca97e4905df9ff

Patch Set 1 #

Patch Set 2 : 2016-08-22 (Monday) 14:56:46 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -32 lines) Patch
M src/pdf/SkPDFDevice.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 4 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
hal.canary
ptal
4 years, 4 months ago (2016-08-22 17:51:48 UTC) #5
hal.canary
fixed
4 years, 4 months ago (2016-08-22 18:57:25 UTC) #9
bungeman-skia
lgtm
4 years, 4 months ago (2016-08-22 18:58:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264113003/20001
4 years, 4 months ago (2016-08-23 16:01:19 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 16:02:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/afdc177e77a4d083a23f709113ca97e4905df9ff

Powered by Google App Engine
This is Rietveld 408576698