Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2264113002: [Extensions] Add feature documentation for id hashes (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, lazyboy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add feature documentation for id hashes BUG=639162 Committed: https://crrev.com/1d458519522511a5b5572494b390cc92590082f6 Cr-Commit-Position: refs/heads/master@{#413557}

Patch Set 1 #

Patch Set 2 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -85 lines) Patch
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/_features.md View 1 2 chunks +46 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +2 lines, -11 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +2 lines, -11 lines 0 comments Download
M extensions/common/api/_behavior_features.json View 1 1 chunk +2 lines, -12 lines 0 comments Download
M extensions/common/api/_manifest_features.json View 1 1 chunk +2 lines, -11 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Devlin
asargent@, mind taking a look? lazyboy@, FYI.
4 years, 4 months ago (2016-08-22 18:33:10 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 4 months ago (2016-08-22 20:04:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264113002/20001
4 years, 4 months ago (2016-08-22 20:14:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/211661) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-22 22:16:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264113002/20001
4 years, 4 months ago (2016-08-22 22:26:14 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 22:35:04 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 22:38:10 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1d458519522511a5b5572494b390cc92590082f6
Cr-Commit-Position: refs/heads/master@{#413557}

Powered by Google App Engine
This is Rietveld 408576698