Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2264103003: Implement support for accessible collapse and expand actions on Android (Closed)

Created:
4 years, 4 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
David Tseng
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cut_copy_paste
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement support for accessible collapse and expand actions on Android What's more important is not implementing the actions themselves (they just trigger a click on the item), but rather whether the item can be collapsed or expanded, which indicates its current state. In other words the only way TalkBack knows to announce that something is currently "collapsed" is if it currently supports the "expand" action. BUG=639956 Committed: https://crrev.com/ce9a740c03ac6bf41b5d745ea4e776466df5cecf Cr-Commit-Position: refs/heads/master@{#414548}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (3 generated)
dmazzoni
4 years, 4 months ago (2016-08-22 21:18:47 UTC) #2
David Tseng
https://codereview.chromium.org/2264103003/diff/1/content/browser/accessibility/browser_accessibility_android.cc File content/browser/accessibility/browser_accessibility_android.cc (right): https://codereview.chromium.org/2264103003/diff/1/content/browser/accessibility/browser_accessibility_android.cc#newcode206 content/browser/accessibility/browser_accessibility_android.cc:206: return HasState(ui::AX_STATE_EXPANDED); Is a widget ever both expanded and ...
4 years, 4 months ago (2016-08-24 22:46:13 UTC) #3
dmazzoni
https://codereview.chromium.org/2264103003/diff/1/content/browser/accessibility/browser_accessibility_android.cc File content/browser/accessibility/browser_accessibility_android.cc (right): https://codereview.chromium.org/2264103003/diff/1/content/browser/accessibility/browser_accessibility_android.cc#newcode206 content/browser/accessibility/browser_accessibility_android.cc:206: return HasState(ui::AX_STATE_EXPANDED); On 2016/08/24 at 22:46:13, David Tseng wrote: ...
4 years, 4 months ago (2016-08-24 22:56:05 UTC) #4
David Tseng
lgtm
4 years, 3 months ago (2016-08-25 16:54:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264103003/1
4 years, 3 months ago (2016-08-25 21:00:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 21:58:46 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 22:00:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce9a740c03ac6bf41b5d745ea4e776466df5cecf
Cr-Commit-Position: refs/heads/master@{#414548}

Powered by Google App Engine
This is Rietveld 408576698