compress_r11eac_blocks() required more alignment than dst has.

compress_r11eac_blocks() required more alignment than dst has.

This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/a61b6d4f9e8ce7134414c84cec075482c2f8efcc

[mtklein_C, 2016-08-22 15:52:10]

Description was changed from

==========
compress_r11eac_blocks() required more alignment than dst has.

This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
==========

to

==========
compress_r11eac_blocks() required more alignment than dst has.

This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-08-22 15:55:32]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 15:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-22 15:58:28]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-08-22 15:58:28]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-22 15:58:28]

Don't worry about not knowing this code... it's a pure NEON intrinsics review.

https://codereview.chromium.org/2264103002/diff/20001/src/opts/SkTextureCompr...
File src/opts/SkTextureCompressor_opts.h (left):

https://codereview.chromium.org/2264103002/diff/20001/src/opts/SkTextureCompr...
src/opts/SkTextureCompressor_opts.h:227: uint64_t* encPtr =
reinterpret_cast<uint64_t*>(dst);
This is where we were going wrong.  dst is not necessarily 8-byte aligned.

[commit-bot: I haz the power, 2016-08-22 15:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 15:58:37]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-08-22 21:58 UTC

[msarett, 2016-08-22 16:19:10]

lgtm

[commit-bot: I haz the power, 2016-08-22 16:30:57]

Description was changed from

==========
compress_r11eac_blocks() required more alignment than dst has.

This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
compress_r11eac_blocks() required more alignment than dst has.

This shouldn't change any behavior except that the stores to dst
will no longer require 8-byte alignment.

Empirically it seems like we can use 4-byte alignment here,
but u8 (i.e. 1-byte alignment) is always safe.

BUG=skia:5637
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264103002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/a61b6d4f9e8ce7134414c84cec075482c2f8efcc
==========

[commit-bot: I haz the power, 2016-08-22 16:30:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a61b6d4f9e8ce7134414c84cec075482c2f8efcc