Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2264093002: [gin] Update Ignition experiment to pass --ignition-staging. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Update Ignition experiment to pass --ignition-staging. Updates the Ignition experiment to pass --ignition-staging (the intended shipping configuration). Also remove lazy and eager variants since we aren't interested in these any longer. BUG=v8:5280, v8:4868 Committed: https://crrev.com/2c39aa416e3b2b9eaa82a64e1af7c6921eb90715 Cr-Commit-Position: refs/heads/master@{#414053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M gin/gin_features.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M gin/public/gin_features.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gin/v8_initializer.cc View 2 chunks +6 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
rmcilroy
Opps, thought I had already sent this for review. Jochen, could you PTAL, thanks.
4 years, 4 months ago (2016-08-23 15:37:23 UTC) #3
rmcilroy
Opps, thought I had already sent this for review. Jochen, could you PTAL, thanks.
4 years, 4 months ago (2016-08-23 15:37:24 UTC) #4
rmcilroy
Ping?
4 years, 4 months ago (2016-08-24 11:13:31 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-24 11:15:37 UTC) #7
rmcilroy
Thanks!
4 years, 4 months ago (2016-08-24 11:19:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264093002/20001
4 years, 4 months ago (2016-08-24 11:19:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-24 12:27:43 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 12:29:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c39aa416e3b2b9eaa82a64e1af7c6921eb90715
Cr-Commit-Position: refs/heads/master@{#414053}

Powered by Google App Engine
This is Rietveld 408576698