Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: content/renderer/media/webrtc_audio_renderer.h

Issue 2264073002: Add UMA histograms for time spent getting WebRTC audio render data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review (Ilya). Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/renderer/media/webrtc_audio_renderer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_
6 #define CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_ 6 #define CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 std::string output_device_id_; 243 std::string output_device_id_;
244 url::Origin security_origin_; 244 url::Origin security_origin_;
245 245
246 // Maps audio sources to a list of active audio renderers. 246 // Maps audio sources to a list of active audio renderers.
247 // Pointers to PlayingState objects are only kept in this map while the 247 // Pointers to PlayingState objects are only kept in this map while the
248 // associated renderer is actually playing the stream. Ownership of the 248 // associated renderer is actually playing the stream. Ownership of the
249 // state objects lies with the renderers and they must leave the playing state 249 // state objects lies with the renderers and they must leave the playing state
250 // before being destructed (PlayingState object goes out of scope). 250 // before being destructed (PlayingState object goes out of scope).
251 SourcePlayingStates source_playing_states_; 251 SourcePlayingStates source_playing_states_;
252 252
253 // Used for triggering new UMA histogram. Counts number of render 253 // Stores the maximum time spent waiting for render data from the source. Used
254 // callbacks modulo |kNumCallbacksBetweenRenderTimeHistograms|. 254 // for logging UMA data. Logged and reset when Stop() is called.
255 int render_callback_count_; 255 base::TimeDelta max_render_time_;
256 256
257 DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcAudioRenderer); 257 DISALLOW_IMPLICIT_CONSTRUCTORS(WebRtcAudioRenderer);
258 }; 258 };
259 259
260 } // namespace content 260 } // namespace content
261 261
262 #endif // CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_ 262 #endif // CONTENT_RENDERER_MEDIA_WEBRTC_AUDIO_RENDERER_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/webrtc_audio_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698