Keep track of the addition order of variables explicitly.

Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_, for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of params_, temps_ and ordered_variables_. In that case we can use a linked list through Variable.

BUG=v8:5209
Committed: https://crrev.com/6ea8b4f2160c1bcd83010664e20874546ec3ac5d
Cr-Commit-Position: refs/heads/master@{#38810}

[Toon Verwaest, 2016-08-22 16:11:28]

Description was changed from

==========
Keep track of unallocated variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and unallocated_. In that case we can use a linked list through
Variable.

BUG=v8:5109
==========

to

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5109
==========

[Toon Verwaest, 2016-08-22 16:11:49]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-08-22 16:11:49]

ptal

[marja, 2016-08-23 08:23:28]

lgtm

[Toon Verwaest, 2016-08-23 08:53:56]

Description was changed from

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5109
==========

to

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5209
==========

[Toon Verwaest, 2016-08-23 08:54:16]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-23 08:54:17]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2264053003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-23 08:54:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 09:18:14]

Description was changed from

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5209
==========

to

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-08-23 09:18:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 09:18:36]

Description was changed from

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5209
==========

to

==========
Keep track of the addition order of variables explicitly.

This avoids needing to allocate a zonelist on the fly later, sorting variables_,
for which we also need to keep track of order in the hashmap.

In a later phase we can make sure that Variable is always uniquely in either of
params_, temps_ and ordered_variables_. In that case we can use a linked list
through Variable.

BUG=v8:5209

Committed: https://crrev.com/6ea8b4f2160c1bcd83010664e20874546ec3ac5d
Cr-Commit-Position: refs/heads/master@{#38810}
==========

[commit-bot: I haz the power, 2016-08-23 09:18:37]

Patchset 3 (id:??) landed as
https://crrev.com/6ea8b4f2160c1bcd83010664e20874546ec3ac5d
Cr-Commit-Position: refs/heads/master@{#38810}