Chromium Code Reviews

Issue 2264033002: [heap] Tracer: Handle incremental marking scopes (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
Reviewers:
jochen (gone - plz use gerrit)
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Tracer: Handle incremental marking scopes Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 R=jochen@chromium.org Committed: https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 Cr-Commit-Position: refs/heads/master@{#38822}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add unittests and more scopes #

Patch Set 3 : Update first incremental scope and add one more object grouping scope #

Patch Set 4 : Add wrapper tracing epilogue scope #

Unified diffs Side-by-side diffs Stats (+357 lines, -205 lines)
M src/heap/gc-tracer.h View 8 chunks +108 lines, -53 lines 0 comments
M src/heap/gc-tracer.cc View 11 chunks +97 lines, -55 lines 0 comments
M src/heap/incremental-marking.cc View 3 chunks +7 lines, -0 lines 0 comments
M src/heap/mark-compact.cc View 3 chunks +4 lines, -0 lines 0 comments
M test/cctest/heap/test-heap.cc View 2 chunks +0 lines, -97 lines 0 comments
M test/unittests/heap/gc-tracer-unittest.cc View 2 chunks +141 lines, -0 lines 0 comments

Messages

Total messages: 26 (18 generated)
Michael Lippautz
ptal https://codereview.chromium.org/2264033002/diff/20001/src/heap/gc-tracer.cc File src/heap/gc-tracer.cc (left): https://codereview.chromium.org/2264033002/diff/20001/src/heap/gc-tracer.cc#oldcode297 src/heap/gc-tracer.cc:297: // TODO(ernstm): move the code below out of ...
4 years, 4 months ago (2016-08-22 12:40:07 UTC) #2
jochen (gone - plz use gerrit)
what about adding a unit test for gc-tracer?
4 years, 4 months ago (2016-08-22 15:50:31 UTC) #8
Michael Lippautz
Done: I moved the cctests we had to the unittest file and created a couple ...
4 years, 4 months ago (2016-08-22 18:21:36 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 12:45:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264033002/100001
4 years, 4 months ago (2016-08-23 12:59:10 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 4 months ago (2016-08-23 13:25:33 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 Cr-Commit-Position: refs/heads/master@{#38822}
4 years, 4 months ago (2016-08-23 13:26:00 UTC) #25
Michael Lippautz
4 years, 4 months ago (2016-08-23 14:14:51 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2275583002/ by mlippautz@chromium.org.

The reason for reverting is: Unittest fails on win32 debug: 
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds....

Powered by Google App Engine