[DevTools] Add error check before _reportDeprecatedCommentIfNeeded call

third_party/WebKit/Source/devtools/front_end/sdk/Script.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 162 matching lines @@
         this.target().debuggerAgent().getScriptSource(this.scriptId, didGetScriptSource.bind(this));
         return promise;
 
         /**
          * @this {WebInspector.Script}
          * @param {?Protocol.Error} error
          * @param {string} source
          */
         function didGetScriptSource(error, source)
         {
-            WebInspector.Script._reportDeprecatedCommentIfNeeded(this, source);
-            this._source = WebInspector.Script._trimSourceURLComment(error ? "" : source);
+            if (!error) {
+                WebInspector.Script._reportDeprecatedCommentIfNeeded(this, source);
+                this._source = WebInspector.Script._trimSourceURLComment(source);

[dgozman, 2016/08/22 16:59:05]

Let's assign empty source in case of error.

[kozy, 2016/08/22 17:10:41]

Done.

+            }
             callback(this._source);
         }
     },
 
     /**
      * @override
      * @param {string} query
      * @param {boolean} caseSensitive
      * @param {boolean} isRegex
      * @param {function(!Array.<!DebuggerAgent.SearchMatch>)} callback
@@ skipping 139 matching lines @@
             {
                 if (error)
                     console.error(error);
                 fulfill(!error);
             }
         }
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }