Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2264013004:
[DevTools] Add error check before _reportDeprecatedCommentIfNeeded call (Closed)
|
Created:
4 years, 4 months ago by kozy Modified:
4 years, 4 months ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Add error check before _reportDeprecatedCommentIfNeeded call
BUG=637609
R=dgozman@chromium.org
Committed: https://crrev.com/1fe5f66561a4f4f081435ab686f3145663b91a0e
Cr-Commit-Position: refs/heads/master@{#413617}
Patch Set 1 #
Total comments: 2
Patch Set 2 : addressed comments #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Dmitry, please take a look!
https://codereview.chromium.org/2264013004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right): https://codereview.chromium.org/2264013004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/Script.js:185: this._source = WebInspector.Script._trimSourceURLComment(source); Let's assign empty source in case of error.
all done https://codereview.chromium.org/2264013004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right): https://codereview.chromium.org/2264013004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/sdk/Script.js:185: this._source = WebInspector.Script._trimSourceURLComment(source); On 2016/08/22 16:59:05, dgozman wrote: > Let's assign empty source in case of error. Done.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Add error check before _reportDeprecatedCommentIfNeeded call BUG=637609 R=dgozman@chromium.org ========== to ========== [DevTools] Add error check before _reportDeprecatedCommentIfNeeded call BUG=637609 R=dgozman@chromium.org Committed: https://crrev.com/1fe5f66561a4f4f081435ab686f3145663b91a0e Cr-Commit-Position: refs/heads/master@{#413617} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1fe5f66561a4f4f081435ab686f3145663b91a0e Cr-Commit-Position: refs/heads/master@{#413617} |
