Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: chrome/browser/download/download_util.h

Issue 22640018: Set up Finch trial for malware download warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: string16 to base string 16 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.h
diff --git a/chrome/browser/download/download_util.h b/chrome/browser/download/download_util.h
index 60288a31007a692d4728603f20904f2f23b1419d..14583e4c7036f7e8fc169f2a6a91063d365fc056 100644
--- a/chrome/browser/download/download_util.h
+++ b/chrome/browser/download/download_util.h
@@ -13,6 +13,7 @@
#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
+#include "base/strings/string_util.h"
#include "ui/gfx/native_widget_types.h"
#if defined(TOOLKIT_VIEWS)
@@ -115,6 +116,28 @@ void RecordDownloadCount(ChromeDownloadCountTypes type);
// Record initiation of a download from a specific source.
void RecordDownloadSource(ChromeDownloadSource source);
+// Summer/Fall 2013 Finch experiment strings -----------------------------------
+// Only deployed to English speakers, don't need translation.
+
+// Study and condition names.
+extern const char kFinchTrialName[];
+extern const char kCondition1Control[];
+extern const char kCondition2Control[];
+extern const char kCondition3Malicious[];
+extern const char kCondition4Unsafe[];
+extern const char kCondition5Dangerous[];
+extern const char kCondition6Harmful[];
+extern const char kCondition7DiscardSecond[];
+extern const char kCondition8DiscardFirst[];
+extern const char kCondition9SafeDiscard[];
+extern const char kCondition10SafeDontRun[];
+
+// Helper for getting the appropriate message for a Finch trial.
+// You should only invoke this if you believe you're in the kFinchTrialName
+// finch trial; if you aren't, use the default string and don't invoke this.
+base::string16 AssembleMalwareFinchString(const std::string& trial_condition,
+ const string16& elided_filename);
Dan Beam 2013/08/09 23:24:51 nit: indent off, base::string16
felt 2013/08/09 23:48:34 Done.
+
} // namespace download_util
#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698