Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: chrome/browser/resources/downloads/downloads.js

Issue 22640018: Set up Finch trial for malware download warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/downloads/downloads.js
diff --git a/chrome/browser/resources/downloads/downloads.js b/chrome/browser/resources/downloads/downloads.js
index c6a625311b8ef2f58a5b357a572366204006a7a1..b9062e75ce638f224570b38b24d082daf827e504 100644
--- a/chrome/browser/resources/downloads/downloads.js
+++ b/chrome/browser/resources/downloads/downloads.js
@@ -423,6 +423,7 @@ Download.prototype.update = function(download) {
this.state_ = download.state;
this.fileExternallyRemoved_ = download.file_externally_removed;
this.dangerType_ = download.danger_type;
+ this.finch_string_ = download.finch_string;
Dan Beam 2013/08/09 18:54:05 this.finchString_
felt 2013/08/09 19:13:15 Done.
this.lastReasonDescription_ = download.last_reason_text;
this.byExtensionId_ = download.by_ext_id;
this.byExtensionName_ = download.by_ext_name;
@@ -452,6 +453,10 @@ Download.prototype.update = function(download) {
this.dangerDesc_.textContent = loadTimeData.getStringF(
'danger_potentially_unwanted_desc', this.fileName_);
}
+ if (this.finch_string_ && this.finch_string_ != '') {
Dan Beam 2013/08/09 18:54:05 empty strings are falsey, don't need the second !=
felt 2013/08/09 19:13:15 Done.
+ // Finch trial overrides the normal display string.
+ this.dangerDesc_.textContent = this.finch_string_;
+ }
this.danger_.style.display = 'block';
this.safe_.style.display = 'none';
} else {

Powered by Google App Engine
This is Rietveld 408576698