chrome/browser/download/download_util_unittest.cc - Issue 22640018: Set up Finch trial for malware download warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/download/download_util_unittest.cc

Issue 22640018: Set up Finch trial for malware download warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: string16 to base string 16 Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/download/download_util.h"

	6

	7 #include "base/strings/string16.h"

	8 #include "base/strings/utf_string_conversions.h"

	9 #include "testing/gtest/include/gtest/gtest.h"

	10

	11 TEST(DownloadUtilTest, FinchStrings) {

	12 EXPECT_EQ(

	13 ASCIIToUTF16("This file is malicious."),

	14 download_util::AssembleMalwareFinchString(

	15 download_util::kCondition3Malicious, string16()));

	16 EXPECT_EQ(

	17 ASCIIToUTF16("File 'malware.exe' is malicious."),

	18 download_util::AssembleMalwareFinchString(

	19 download_util::kCondition3Malicious, ASCIIToUTF16("malware.exe")));

	20 }
	Dan Beam 2013/08/09 23:24:51 nit: remove blank line (IMO) nit: remove blank line (IMO) felt 2013/08/09 23:48:34 the linter complains without it Show quoted text On 2013/08/09 23:24:51, Dan Beam wrote: > nit: remove blank line (IMO) the linter complains without it Dan Beam 2013/08/10 00:10:14 if you're talking about "1 error" next to your pat Show quoted text On 2013/08/09 23:48:34, felt wrote: > On 2013/08/09 23:24:51, Dan Beam wrote: > > nit: remove blank line (IMO) > > the linter complains without it if you're talking about "1 error" next to your patchset, nobody listens to that. felt 2013/08/10 00:33:00 Done. Show quoted text On 2013/08/10 00:10:14, Dan Beam wrote: > On 2013/08/09 23:48:34, felt wrote: > > On 2013/08/09 23:24:51, Dan Beam wrote: > > > nit: remove blank line (IMO) > > > > the linter complains without it > > if you're talking about "1 error" next to your patchset, nobody listens to that. Done.
	21

OLD	NEW

« chrome/browser/download/download_util.cc ('K') | « chrome/browser/download/download_util.cc ('k') | chrome/browser/resources/downloads/downloads.js » ('j') | no next file with comments »