content/renderer/media/media_stream_dependency_factory.cc - Issue 22640017: Passing NULL PeerConnectionIdentityService to Libjingle when Chrome is using openssl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 22640017: Passing NULL PeerConnectionIdentityService to Libjingle when Chrome is using openssl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/media_stream_dependency_factory.cc

diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc

index 7f5e64aa187ffe65a2b1995e102f5a64b5809aef..28e0ce85f62d14a012505002c19c8aaec1c39ae6 100644

--- a/content/renderer/media/media_stream_dependency_factory.cc

+++ b/content/renderer/media/media_stream_dependency_factory.cc

@@ -551,8 +551,8 @@ MediaStreamDependencyFactory::CreatePeerConnection(

web_frame);

PeerConnectionIdentityService* identity_service =

- new PeerConnectionIdentityService(GURL(web_frame->document().url().spec())

- .GetOrigin());

+ PeerConnectionIdentityService::Create(

juberti2 2013/08/09 20:23:39 Suggest adding a comment to indicate that a NULL r

+ GURL(web_frame->document().url().spec()).GetOrigin());

return pc_factory_->CreatePeerConnection(ice_servers,

constraints,

« no previous file with comments | « no previous file | content/renderer/media/peer_connection_identity_service.h » ('j') | no next file with comments »