[parser] Modify some const qualifications

[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/dc18cc1d4f4ac2f50111ccfa2f93ca9d10f4c54b
Cr-Commit-Position: refs/heads/master@{#38813}

[nickie, 2016-08-22 11:56:14]

Marja and I discussed about the changes to AstNodeFactory.  It seems a better
option to leave out the const qualifications from AstNodeFactory::New* methods,
as in principle these methods should be able to change the factory's state. 
There will be an updated patch set shortly.

[nickie, 2016-08-22 13:22:17]

Description was changed from

==========
[parser] Qualify some methods as const

This patch qualifies as const some methods of the following objects:
AstNodeFactory, ParserBase, Parser.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[nickie, 2016-08-22 13:23:06]

On 2016/08/22 11:56:14, nickie wrote:
> Marja and I discussed about the changes to AstNodeFactory.  It seems a better
> option to leave out the const qualifications from AstNodeFactory::New*
methods,
> as in principle these methods should be able to change the factory's state. 
> There will be an updated patch set shortly.

Done.

[nickie, 2016-08-22 13:23:20]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 13:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 13:46:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 13:46:05]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-22 18:49:40]

lgtm

[marja, 2016-08-23 08:29:33]

lgtm

[nickie, 2016-08-23 08:31:31]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-08-23 08:31:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 08:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 08:35:53]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22335)

[nickie, 2016-08-23 09:53:57]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-23 09:53:58]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2263973003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-23 09:54:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 09:58:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 09:58:11]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22342)

[nickie, 2016-08-23 10:08:01]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-23 10:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2263973003/#ps60001
(title: "Formatting")

[commit-bot: I haz the power, 2016-08-23 10:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 10:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 10:13:22]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[nickie, 2016-08-23 10:17:34]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-08-23 10:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2263973003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-23 10:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 10:39:00]

Description was changed from

==========
[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

[commit-bot: I haz the power, 2016-08-23 10:39:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-23 10:39:23]

Description was changed from

==========
[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Modify some const qualifications

This patch const-qualifies some methods of ParserBase.
It also unqualifies some methods of Parser and Preparser.
The reason for the latter is that, in principle, the methods
of AstNodeFactory should be allowed to change the factory's
state, therefore should not be const and should not be used
from const-qualified parser/pre-parser methods.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/dc18cc1d4f4ac2f50111ccfa2f93ca9d10f4c54b
Cr-Commit-Position: refs/heads/master@{#38813}
==========

[commit-bot: I haz the power, 2016-08-23 10:39:24]

Patchset 5 (id:??) landed as
https://crrev.com/dc18cc1d4f4ac2f50111ccfa2f93ca9d10f4c54b
Cr-Commit-Position: refs/heads/master@{#38813}