Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2263973002: md-history: Fix a search field regression caused by r410495.

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, calamity, chromium-reviews, dbeam+watch-elements_chromium.org, dbeam+watch-history_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, tsergeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

md-history: Fix a search field regression caused by r410495. The original behavior before r410495 depended on 1px margin-end specified by UA stylesheet for -webkit-search-cancel-button. After r410495, the search field correctly moves the cancel button to the left side. This CL recovers the original behavior by adding margin-end to paper-input-container. Also, this CL removes selectors for -webkit-search-decoration and -webkit-search-results-button from cr_toolbar_search_field.html. These pseudo elements were removed from Blink. This CL doesn't intent to fix other existing issues. - We should secure space for the custom clear button at the right side, or - We should flip the position of the custom clear button; crbug.com/638484 BUG=639256 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
tkent
dbeam@, would you review this please?
4 years, 4 months ago (2016-08-22 08:15:36 UTC) #5
Dan Beam
4 years, 4 months ago (2016-08-23 00:09:35 UTC) #8
/cc tsergeant, calamity as FYI

Powered by Google App Engine
This is Rietveld 408576698