Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8255)

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 2263933002: Make FormFetcher a PasswordStoreConsumer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_form_fetcher
Patch Set: Also operator= is now default Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_password_form_manager.cc
diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.cc b/components/password_manager/core/browser/credential_manager_password_form_manager.cc
index e26a6883abbe6349fcc613d79e92beefa52ff77d..51e6bb348280ba87a4348bdaf104d6bfd283c870 100644
--- a/components/password_manager/core/browser/credential_manager_password_form_manager.cc
+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.cc
@@ -28,7 +28,8 @@ CredentialManagerPasswordFormManager::CredentialManagerPasswordFormManager(
client,
driver,
observed_form,
- base::WrapUnique(new FormSaverImpl(client->GetPasswordStore()))),
+ base::WrapUnique(new FormSaverImpl(client->GetPasswordStore())),
+ nullptr),
delegate_(delegate),
saved_form_(std::move(saved_form)) {
DCHECK(saved_form_);
@@ -37,9 +38,10 @@ CredentialManagerPasswordFormManager::CredentialManagerPasswordFormManager(
CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {
}
-void CredentialManagerPasswordFormManager::OnGetPasswordStoreResults(
- std::vector<std::unique_ptr<autofill::PasswordForm>> results) {
- PasswordFormManager::OnGetPasswordStoreResults(std::move(results));
+void CredentialManagerPasswordFormManager::ProcessMatches(
+ const std::vector<const PasswordForm*>& non_federated,
+ size_t filtered_count) {
+ PasswordFormManager::ProcessMatches(non_federated, filtered_count);
// Mark the form as "preferred", as we've been told by the API that this is
// indeed the credential set that the user used to sign into the site.

Powered by Google App Engine
This is Rietveld 408576698