Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 22639003: Update sync_file_system.idl to use a regular array instead of an EntryArray (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, fmalita_google_do_not_use
Visibility:
Public.

Description

Update sync_file_system.idl to use a regular array instead of an EntryArray After Blink r155749, the File API's readEntries() now returns a Entry[] instead of an EntryArray type, to match the specification. This patch updates the sync_file_system extension API accordingly to fix breakage. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216649

Patch Set 1 #

Total comments: 1

Patch Set 2 : Unskip test in the same patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/extensions/api/sync_file_system.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-08 15:34:49 UTC) #1
do-not-use
This fixes the following browser test: SyncFileSystemApiTest.GetFileStatuses
7 years, 4 months ago (2013-08-08 15:35:33 UTC) #2
do-not-use
7 years, 4 months ago (2013-08-08 15:43:13 UTC) #3
not at google - send to devlin
lgtm because this fixes a test, but we probably want better than object[] there. +kinuko ...
7 years, 4 months ago (2013-08-08 15:46:39 UTC) #4
do-not-use
https://codereview.chromium.org/22639003/diff/1/chrome/common/extensions/api/sync_file_system.idl File chrome/common/extensions/api/sync_file_system.idl (right): https://codereview.chromium.org/22639003/diff/1/chrome/common/extensions/api/sync_file_system.idl#newcode173 chrome/common/extensions/api/sync_file_system.idl:173: static void getFileStatuses(object[] fileEntries, Yes, the singular version above ...
7 years, 4 months ago (2013-08-08 15:49:17 UTC) #5
not at google - send to devlin
Yes just submit. We can worry about what it should be later.
7 years, 4 months ago (2013-08-08 15:56:03 UTC) #6
kinuko
Thanks for the quick fix! Yes we can take care of it after it's submitted.
7 years, 4 months ago (2013-08-08 16:19:49 UTC) #7
do-not-use
I updated the CL to unskip the browser test in the same patch (fmalita@ skipped ...
7 years, 4 months ago (2013-08-08 18:15:17 UTC) #8
f(malita)
On 2013/08/08 18:15:17, Christophe Dumez wrote: > I updated the CL to unskip the browser ...
7 years, 4 months ago (2013-08-08 18:25:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22639003/13001
7 years, 4 months ago (2013-08-08 22:00:30 UTC) #10
commit-bot: I haz the power
7 years, 4 months ago (2013-08-09 10:15:47 UTC) #11
Message was sent while issue was closed.
Change committed as 216649

Powered by Google App Engine
This is Rietveld 408576698