Deliver change notifications to SourceBuffer track lists.

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 2390 matching lines @@
     else
         pause();
 }
 
 AudioTrackList& HTMLMediaElement::audioTracks()
 {
     DCHECK(RuntimeEnabledFeatures::audioVideoTracksEnabled());
     return *m_audioTracks;
 }
 
-void HTMLMediaElement::audioTrackChanged(WebMediaPlayer::TrackId trackId, bool enabled)
+void HTMLMediaElement::audioTrackChanged(AudioTrack* track)
 {
-    BLINK_MEDIA_LOG << "audioTrackChanged(" << (void*)this << ") trackId= " << String(trackId) << " enabled=" << boolString(enabled);
+    BLINK_MEDIA_LOG << "audioTrackChanged(" << (void*)this << ") trackId= " << String(track->id()) << " enabled=" << boolString(track->enabled());
     DCHECK(RuntimeEnabledFeatures::audioVideoTracksEnabled());
 
     audioTracks().scheduleChangeEvent();
 
-    // FIXME: Add call on m_mediaSource to notify it of track changes once the SourceBuffer.audioTracks attribute is added.
+    if (m_mediaSource)
+        m_mediaSource->onTrackChanged(track);
 
     if (!m_audioTracksTimer.isActive())
         m_audioTracksTimer.startOneShot(0, BLINK_FROM_HERE);
 }
 
 void HTMLMediaElement::audioTracksTimerFired(TimerBase*)
 {
     Vector<WebMediaPlayer::TrackId> enabledTrackIds;
     for (unsigned i = 0; i < audioTracks().length(); ++i) {
         AudioTrack* track = audioTracks().anonymousIndexedGetter(i);
@@ skipping 28 matching lines @@
 
     audioTracks().remove(trackId);
 }
 
 VideoTrackList& HTMLMediaElement::videoTracks()
 {
     DCHECK(RuntimeEnabledFeatures::audioVideoTracksEnabled());
     return *m_videoTracks;
 }
 
-void HTMLMediaElement::selectedVideoTrackChanged(WebMediaPlayer::TrackId* selectedTrackId)
+void HTMLMediaElement::selectedVideoTrackChanged(VideoTrack* track)
 {
-    BLINK_MEDIA_LOG << "selectedVideoTrackChanged(" << (void*)this << ") selectedTrackId=" << (selectedTrackId ? String(*selectedTrackId) : "none");
+    BLINK_MEDIA_LOG << "selectedVideoTrackChanged(" << (void*)this << ") selectedTrackId=" << (track->selected() ? String(track->id()) : "none");
     DCHECK(RuntimeEnabledFeatures::audioVideoTracksEnabled());
 
-    if (selectedTrackId)
-        videoTracks().trackSelected(*selectedTrackId);
+    if (track->selected())
+        videoTracks().trackSelected(track->id());
 
-    // FIXME: Add call on m_mediaSource to notify it of track changes once the SourceBuffer.videoTracks attribute is added.
+    videoTracks().scheduleChangeEvent();
 
-    webMediaPlayer()->selectedVideoTrackChanged(selectedTrackId);
+    if (m_mediaSource)
+        m_mediaSource->onTrackChanged(track);
+
+    WebMediaPlayer::TrackId id = track->id();
+    webMediaPlayer()->selectedVideoTrackChanged(track->selected() ? &id : nullptr);

[mlamouri (slow - plz ping), 2016/08/24 16:08:46]

Should you pass `&track->id()` instead of making a copy on the stack and passing
the pointer?

[servolk, 2016/08/25 00:50:18]

No, that causes an error:
../../third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2481:69: error:
taking the address of a temporary object of type 'WebMediaPlayer::TrackId' (aka
'blink::WebString') [-Waddress-of-temporary]
    webMediaPlayer()->selectedVideoTrackChanged(track->selected() ? &track->id()
: nullptr);
So I had to use an explicit temp variable.

 }
 
 WebMediaPlayer::TrackId HTMLMediaElement::addVideoTrack(const WebString& id, WebMediaPlayerClient::VideoTrackKind kind, const WebString& label, const WebString& language, bool selected)
 {
     AtomicString kindString = VideoKindToString(kind);
     BLINK_MEDIA_LOG << "addVideoTrack(" << (void*)this << ", '" << (String)id << "', '" << (AtomicString)kindString
         << "', '" << (String)label << "', '" << (String)language << "', " << boolString(selected) << ")";
 
     if (!RuntimeEnabledFeatures::audioVideoTracksEnabled())
         return blink::WebMediaPlayer::TrackId();
@@ skipping 1534 matching lines @@
 
 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() const
 {
     IntRect result;
     if (LayoutObject* object = m_element->layoutObject())
         result = object->absoluteBoundingBoxRect();
     return result;
 }
 
 } // namespace blink