third_party/WebKit/LayoutTests/media/avtrack/video-track-selected.html - Issue 2263823002: Deliver change notifications to SourceBuffer track lists.

Side by Side Diff: third_party/WebKit/LayoutTests/media/avtrack/video-track-selected.html

Issue 2263823002: Deliver change notifications to SourceBuffer track lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed video-track-selected test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-avtracks.html ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>VideoTrack.selected change</title>	4 <title>VideoTrack.selected change</title>

5 <script src="../../resources/testharness.js"></script>	5 <script src="../../resources/testharness.js"></script>

6 <script src="../../resources/testharnessreport.js"></script>	6 <script src="../../resources/testharnessreport.js"></script>

7 <script src="../media-file.js"></script>	7 <script src="../media-file.js"></script>

8 </head>	8 </head>

9 <body>	9 <body>

10 <div id="log"></div>	10 <div id="log"></div>

11 <script>	11 <script>

12 async_test(function(t)	12 async_test(function(t)

13 {	13 {

14 var e = document.createElement("video");	14 var e = document.createElement("video");

15 e.src = findMediaFile("video", "../content/test");	15 e.src = findMediaFile("video", "../content/test");

16	16

17 e.onloadedmetadata = t.step_func(function()	17 e.onloadedmetadata = t.step_func(function()

18 {	18 {

19 assert_equals(e.videoTracks.length, 1, "videoTracks.length") ;	19 assert_equals(e.videoTracks.length, 1, "videoTracks.length") ;

20 assert_equals(e.videoTracks.selectedIndex, 0, "videoTracks.s electedIndex (initial)");	20 assert_equals(e.videoTracks.selectedIndex, 0, "videoTracks.s electedIndex (initial)");

21 assert_true(e.videoTracks[0].selected, "videoTrack.selected (initial)");	21 assert_true(e.videoTracks[0].selected, "videoTrack.selected (initial)");

22 e.videoTracks[0].selected = false;	22 e.videoTracks[0].selected = false;

23 assert_equals(e.videoTracks.selectedIndex, -1, "videoTracks. selectedIndex (first setter)");	23 assert_equals(e.videoTracks.selectedIndex, -1, "videoTracks. selectedIndex (first setter)");

24 assert_false(e.videoTracks[0].selected, "videoTrack.selected (first setter)");	24 assert_false(e.videoTracks[0].selected, "videoTrack.selected (first setter)");

25	25

26 e.videoTracks.onchange = t.unreached_func("setting selected to false fired change event");	26 e.videoTracks.onchange = t.step_func(function()
servolk 2016/08/22 17:37:36 Note: I'm changing this intentionally. It looks li Note: I'm changing this intentionally. It looks like the current check is incorrect, the change event must be fired even when the video track is deselected. According to https://www.w3.org/TR/html/single-page.html#audiotracklist-and-videotracklist...: ... Whenever a track in a VideoTrackList that was previously not selected is selected, and whenever the selected track in a VideoTrackList is unselected without a new track being selected in its stead, the user agent must queue a task to fire a simple event named change at the VideoTrackList object. ...
27 setTimeout(t.step_func(function()

28 {	27 {

	28 assert_false(e.videoTracks[0].selected, "videoTrack.sele cted (first setter)");

29 e.videoTracks[0].selected = true;	29 e.videoTracks[0].selected = true;

30 assert_equals(e.videoTracks.selectedIndex, 0, "videoTrac ks.selectedIndex (second setter)");	30 assert_equals(e.videoTracks.selectedIndex, 0, "videoTrac ks.selectedIndex (second setter)");

31 assert_true(e.videoTracks[0].selected, "videoTrack.selec ted (second setter)");	31 assert_true(e.videoTracks[0].selected, "videoTrack.selec ted (second setter)");

32	32

33 e.videoTracks.onchange = t.step_func(function()	33 e.videoTracks.onchange = t.step_func(function()

34 {	34 {

35 assert_equals(e.videoTracks.selectedIndex, 0, "video Tracks.selectedIndex (change event)");	35 assert_equals(e.videoTracks.selectedIndex, 0, "video Tracks.selectedIndex (change event)");

36 assert_true(e.videoTracks[0].selected, "videoTrack.s elected (change event)");	36 assert_true(e.videoTracks[0].selected, "videoTrack.s elected (change event)");

37 t.done();	37 t.done();

38 });	38 });

39 }), 0);	39 });

40 });	40 });

41 }, "VideoTrackList track change");	41 }, "VideoTrackList track change");

42 </script>	42 </script>

43 </body>	43 </body>

44 </html>	44 </html>

OLD	NEW