Workaround for Strict Mode issues on L Consumer devices.

Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main layout.
This works around Strict Mode violations we're seeing on tests running on the L Consumer configuration.

BUG=639352
Committed: https://crrev.com/acd088a7ef6ec0ca53889ca735ada8a0151581a7
Cr-Commit-Position: refs/heads/master@{#413299}

[Donn Denman, 2016-08-19 23:08:06]

donnd@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Donn Denman, 2016-08-19 23:08:07]

Ted, PTAL.  THANKS!

[Ted C, 2016-08-19 23:29:52]

lgtm

https://chromiumcodereview.appspot.com/2263793002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/2263793002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:345: //
Allow disk access here so tests can update the content view.  See
crbug.com/639352.
I believe this would fail on that device regardless of it being in a test.  I
think this comment should be that on certain android configurations
setContentView results in disk writes outside of our control.  So, we have to
disable StrictView to work.

[Donn Denman, 2016-08-19 23:39:54]

Description was changed from

==========
Workaround for Strict Mode issues with tests on L Consumer.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around a consistent bot failure we're seeing on many tests running
on the L Consumer configuration.

BUG=639352
==========

to

==========
Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around Strict Mode violations we're seeing on tests running on the L
Consumer configuration.

BUG=639352
==========

[Donn Denman, 2016-08-19 23:40:08]

Thanks Ted!

https://chromiumcodereview.appspot.com/2263793002/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/2263793002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:345: //
Allow disk access here so tests can update the content view.  See
crbug.com/639352.
On 2016/08/19 23:29:51, Ted C wrote:
> I believe this would fail on that device regardless of it being in a test.  I
> think this comment should be that on certain android configurations
> setContentView results in disk writes outside of our control.  So, we have to
> disable StrictView to work.

Updated with your comment, except said "... have to disable StrictMode ..."
instead of "... have to disable StrictView ...".

Thanks for the clarification details!

[Donn Denman, 2016-08-19 23:40:17]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2016-08-19 23:40:18]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2263793002/#ps20001
(title: "Just updated a comment.")

[commit-bot: I haz the power, 2016-08-19 23:41:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:48:53]

Description was changed from

==========
Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around Strict Mode violations we're seeing on tests running on the L
Consumer configuration.

BUG=639352
==========

to

==========
Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around Strict Mode violations we're seeing on tests running on the L
Consumer configuration.

BUG=639352
==========

[commit-bot: I haz the power, 2016-08-20 00:48:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-20 00:51:06]

Description was changed from

==========
Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around Strict Mode violations we're seeing on tests running on the L
Consumer configuration.

BUG=639352
==========

to

==========
Workaround for Strict Mode issues on L Consumer devices.

Allow disk writes when the activity is setting the content view for the main
layout.
This works around Strict Mode violations we're seeing on tests running on the L
Consumer configuration.

BUG=639352

Committed: https://crrev.com/acd088a7ef6ec0ca53889ca735ada8a0151581a7
Cr-Commit-Position: refs/heads/master@{#413299}
==========

[commit-bot: I haz the power, 2016-08-20 00:51:07]

Patchset 2 (id:??) landed as
https://crrev.com/acd088a7ef6ec0ca53889ca735ada8a0151581a7
Cr-Commit-Position: refs/heads/master@{#413299}