Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2263763002: Allow testing of Update 3 final (Closed)

Created:
4 years, 4 months ago by brucedawson
Modified:
4 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Bret
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow testing of Update 3 final Upgrading to Update 3 is hitting a few roadblocks, which is preventing Windows developers from getting its fast-incremental-linking goodness. This change lets developers opt-in to using it by going: set DEPOT_TOOLS_WIN_TOOLCHAIN_PRERELEASE=1 gclient runhooks If the environment variable is not set then this has no effect. BUG=627216 Committed: https://crrev.com/0ea25a46ed83e529d928190cbf3259964acd3ad1 Cr-Commit-Position: refs/heads/master@{#413279}

Patch Set 1 #

Patch Set 2 : Allow testing of Update 3 final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/vs_toolchain.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
brucedawson
4 years, 4 months ago (2016-08-19 22:23:26 UTC) #3
scottmg
"with patches" is just the final-final-Update 3, right? lgtm
4 years, 4 months ago (2016-08-19 22:30:35 UTC) #4
brucedawson
On 2016/08/19 22:30:35, scottmg wrote: > "with patches" is just the final-final-Update 3, right? Yeah, ...
4 years, 4 months ago (2016-08-19 22:34:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263763002/20001
4 years, 4 months ago (2016-08-19 22:35:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 23:17:29 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 23:18:35 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ea25a46ed83e529d928190cbf3259964acd3ad1
Cr-Commit-Position: refs/heads/master@{#413279}

Powered by Google App Engine
This is Rietveld 408576698