Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2263703002:
Revert of Disable broken WebKit tests on Win7 Debug (Closed)
DescriptionRevert of Disable broken WebKit tests on Win7 Debug (patchset #1 id:1 of https://codereview.chromium.org/2263563002/ )
Reason for revert:
Bug should be fixed. Reenabling tests.
Original issue's description:
> Disable broken WebKit tests on Win7 Debug
>
> BUG=639179
> TBR=msarett@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/a6957723d980c818d451f51f926ad9f4a4378ad0
> Cr-Commit-Position: refs/heads/master@{#413114}
TBR=treib@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=639179
Committed: https://crrev.com/74392416c7254103ab86293f98c3c024105429e2
Cr-Commit-Position: refs/heads/master@{#413228}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Messages
Total messages: 23 (11 generated)
The CQ bit was checked by msarett@google.com
Created Revert of Disable broken WebKit tests on Win7 Debug
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
msarett@google.com changed reviewers: + robertphillips@chromium.org
lgtm
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1306 Falling back to three-way merge... Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with conflicts. U third_party/WebKit/LayoutTests/TestExpectations Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 6c3cedfc91699c1e29bc3bbbeb03ed48c637599a..1689fddd41845a54e255d9e70e21b49f62876403 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1306,11 +1306,3 @@ crbug.com/490015 virtual/stable/http/tests/navigation/same-and-different-back.html [ Skip ] crbug.com/638850 [ Mac10.10 ] svg/custom/repaint-on-constant-size-change.svg [ Pass Failure ] - -crbug.com/639179 [ Win7 Debug ] compositing/reflections/nested-reflection-transformed.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] compositing/reflections/nested-reflection-transformed2.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] compositing/reflections/reflection-in-composited.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] css3/filters/filter-repaint-shadow-rotated.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] fast/css/transformed-mask.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] fast/reflections/opacity-reflection-transform.html [ Skip ] -crbug.com/639179 [ Win7 Debug ] fast/repaint/reflection-repaint-test.html [ Skip ]
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@chromium.org Link to the patchset: https://codereview.chromium.org/2263703002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1308 Falling back to three-way merge... Applied patch to 'third_party/WebKit/LayoutTests/TestExpectations' with conflicts. U third_party/WebKit/LayoutTests/TestExpectations Patch: third_party/WebKit/LayoutTests/TestExpectations Index: third_party/WebKit/LayoutTests/TestExpectations diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations index 953006cafaa3ddff161205d2a9f0859398d7b66a..ade0041574774ebe0a19dbb815508f90471254d2 100644 --- a/third_party/WebKit/LayoutTests/TestExpectations +++ b/third_party/WebKit/LayoutTests/TestExpectations @@ -1308,11 +1308,3 @@ crbug.com/490015 virtual/stable/http/tests/navigation/beacon-blob-with-non-simpl crbug.com/490015 virtual/stable/http/tests/navigation/same-and-different-back.html [ Skip ] crbug.com/638850 [ Mac10.10 ] svg/custom/repaint-on-constant-size-change.svg [ Pass Failure ] - -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] compositing/reflections/nested-reflection-transformed.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] compositing/reflections/nested-reflection-transformed2.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] compositing/reflections/reflection-in-composited.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] css3/filters/filter-repaint-shadow-rotated.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] fast/css/transformed-mask.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] fast/reflections/opacity-reflection-transform.html [ Skip ] -crbug.com/639179 [ Win7 Mac10.11 Linux Debug ] fast/repaint/reflection-repaint-test.html [ Skip ]
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@chromium.org Link to the patchset: https://codereview.chromium.org/2263703002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable broken WebKit tests on Win7 Debug (patchset #1 id:1 of https://codereview.chromium.org/2263563002/ ) Reason for revert: Bug should be fixed. Reenabling tests. Original issue's description: > Disable broken WebKit tests on Win7 Debug > > BUG=639179 > TBR=msarett@chromium.org > NOTRY=true > > Committed: https://crrev.com/a6957723d980c818d451f51f926ad9f4a4378ad0 > Cr-Commit-Position: refs/heads/master@{#413114} TBR=treib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639179 ========== to ========== Revert of Disable broken WebKit tests on Win7 Debug (patchset #1 id:1 of https://codereview.chromium.org/2263563002/ ) Reason for revert: Bug should be fixed. Reenabling tests. Original issue's description: > Disable broken WebKit tests on Win7 Debug > > BUG=639179 > TBR=msarett@chromium.org > NOTRY=true > > Committed: https://crrev.com/a6957723d980c818d451f51f926ad9f4a4378ad0 > Cr-Commit-Position: refs/heads/master@{#413114} TBR=treib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639179 Committed: https://crrev.com/74392416c7254103ab86293f98c3c024105429e2 Cr-Commit-Position: refs/heads/master@{#413228} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/74392416c7254103ab86293f98c3c024105429e2 Cr-Commit-Position: refs/heads/master@{#413228} |
