Add palm suppression feature to EventConverterEvdev

ui/events/ozone/evdev/input_device_factory_evdev.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/ozone/evdev/input_device_factory_evdev.h"
 
 #include <fcntl.h>
 #include <linux/input.h>
 #include <stddef.h>
 
@@ skipping 221 matching lines @@
     const base::FilePath& path = converter->path();
 
     TRACE_EVENT1("evdev", "AttachInputDevice", "path", path.value());
     DCHECK(task_runner_->RunsTasksOnCurrentThread());
 
     // If we have an existing device, detach it. We don't want two
     // devices with the same name open at the same time.
     if (converters_[path])
       DetachInputDevice(path);
 
+    if (converter->type() == InputDeviceType::INPUT_DEVICE_INTERNAL &&
+        converter->HasPen())

[spang, 2016/08/26 22:20:03]

Please add braces when the body spans more than one line (even if it is one
statement).

[denniskempin, 2016/08/26 23:02:07]

Done.

+      converter->SetPalmSuppressionCallback(
+          base::Bind(&InputDeviceFactoryEvdev::EnablePalmSuppression,
+                     base::Unretained(this)));
+
     // Add initialized device to map.
     converters_[path] = converter.release();
     converters_[path]->Start();
     UpdateDirtyFlags(converters_[path]);
 
     // Sync settings to new device.
     ApplyInputDeviceSettings();
     ApplyCapsLockLed();
   }
 
@@ skipping 117 matching lines @@
     const EventConverterEvdev* converter) {
   if (!input_device_settings_.enable_internal_touchpad &&
       converter->type() == InputDeviceType::INPUT_DEVICE_INTERNAL &&
       converter->HasTouchpad())
     return false;
 
   if (!input_device_settings_.enable_touch_screens &&
       converter->HasTouchscreen())
     return false;
 
+  if (palm_suppression_enabled_ &&
+      converter->type() == InputDeviceType::INPUT_DEVICE_INTERNAL &&
+      converter->HasTouchscreen() && !converter->HasPen())
+    return false;
+
   return input_device_settings_.enable_devices;
 }
 
 void InputDeviceFactoryEvdev::UpdateDirtyFlags(
     const EventConverterEvdev* converter) {
   if (converter->HasTouchscreen())
     touchscreen_list_dirty_ = true;
 
   if (converter->HasKeyboard())
     keyboard_list_dirty_ = true;
@@ skipping 95 matching lines @@
 #if defined(USE_EVDEV_GESTURES)
   std::vector<int> ids;
   gesture_property_provider_->GetDeviceIdsByType(type, &ids);
   for (size_t i = 0; i < ids.size(); ++i) {
     SetGestureBoolProperty(gesture_property_provider_.get(), ids[i], name,
                            value);
   }
 #endif
 }
 
+void InputDeviceFactoryEvdev::EnablePalmSuppression(bool enabled) {
+  if (enabled == palm_suppression_enabled_)
+    return;
+  palm_suppression_enabled_ = enabled;
+
+  for (const auto& it : converters_) {
+    it.second->SetEnabled(IsDeviceEnabled(it.second));
+  }
+}
+
 }  // namespace ui