Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java

Issue 2263673003: Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pkotwicz@'s comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
index a4da684a344708f7e4135d4d33545c9d070bc8ee..5a7d164789062546cd9e307cfbb9775ddd418b28 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
@@ -66,8 +66,9 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
}
@Override
- public void onUpgradeNeededCheckFinished(boolean needsUpgrade, WebappInfo newInfo) {
- if (needsUpgrade) updateAsync(newInfo);
+ public void onUpgradeNeededCheckFinished(boolean needsUpgrade,
+ ManifestUpgradeDetector.FetchedManifestData data) {
+ if (needsUpgrade) updateAsync(data);
if (mUpgradeDetector != null) {
mUpgradeDetector.destroy();
}
@@ -76,15 +77,14 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
/**
* Sends request to WebAPK Server to update WebAPK.
- * @param webappInfo The new fetched Web Manifest data of the WebAPK.
*/
- public void updateAsync(WebappInfo webappInfo) {
- int webApkVersion = getVersionFromMetaData(webappInfo.webApkPackageName());
- nativeUpdateAsync(webappInfo.uri().toString(), webappInfo.scopeUri().toString(),
- webappInfo.name(), webappInfo.shortName(), "", webappInfo.icon(),
- webappInfo.displayMode(), webappInfo.orientation(), webappInfo.themeColor(),
- webappInfo.backgroundColor(), mUpgradeDetector.getManifestUrl(),
- webappInfo.webApkPackageName(), webApkVersion);
+ public void updateAsync(ManifestUpgradeDetector.FetchedManifestData data) {
+ String packageName = mUpgradeDetector.getWebApkPackageName();
+ int webApkVersion = getVersionFromMetaData(packageName);
+ nativeUpdateAsync(data.startUrl, data.scopeUrl, data.name, data.shortName, data.iconUrl,
+ Long.toString(data.iconMurmur2Hash), data.icon, data.displayMode, data.orientation,
+ data.themeColor, data.backgroundColor, mUpgradeDetector.getManifestUrl(),
+ packageName, webApkVersion);
}
public void destroy() {
@@ -126,7 +126,7 @@ public class WebApkUpdateManager implements ManifestUpgradeDetector.Callback {
}
private static native void nativeUpdateAsync(String startUrl, String scope, String name,
- String shortName, String iconUrl, Bitmap icon, int displayMode, int orientation,
- long themeColor, long backgroundColor, String manifestUrl, String webApkPackage,
- int webApkVersion);
+ String shortName, String iconUrl, String iconMurmur2Hash, Bitmap icon, int displayMode,
+ int orientation, long themeColor, long backgroundColor, String manifestUrl,
+ String webApkPackage, int webApkVersion);
}

Powered by Google App Engine
This is Rietveld 408576698