Pass icon and icon murmur2 hash to WebApkInstaller when updating WebAPKs.

chrome/browser/android/webapk/webapk_installer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include <jni.h>
 #include <memory>
 #include <string>
 
@@ skipping 82 matching lines @@
     WebApkInstaller* installer = CreateWebApkInstaller();
 
     installer->InstallAsyncWithURLRequestContextGetter(
         url_request_context_getter_.get(),
         base::Bind(&WebApkInstallerRunner::OnCompleted,
                    base::Unretained(this)));
     Run();
   }
 
   void RunUpdateWebApk() {
-    const int webapk_version = 1;
+    const int kWebApkVersion = 1;
+    const std::string kIconMurmur2Hash = "0";

[pkotwicz, 2016/08/26 21:24:37]

Nit: Order |kIconMurmur2Hash| before |kWebApkVersion| to match order that the
arguments are passed to
WebApkInstaller::UpdateAsyncWithURLRequestContextGetter()

[Xi Han, 2016/08/29 15:33:22]

Done.

 
     WebApkInstaller* installer = CreateWebApkInstaller();
 
     installer->UpdateAsyncWithURLRequestContextGetter(
         url_request_context_getter_.get(),
         base::Bind(&WebApkInstallerRunner::OnCompleted, base::Unretained(this)),
+        kIconMurmur2Hash,
         kDownloadedWebApkPackageName,
-        webapk_version);
+        kWebApkVersion);
 
     Run();
   }
 
   WebApkInstaller* CreateWebApkInstaller() {
     ShortcutInfo info(GURL::EmptyGURL());
     info.icon_url = icon_url_;
 
     // WebApkInstaller owns itself.
     WebApkInstaller* installer = new TestWebApkInstaller(info, SkBitmap());
@@ skipping 209 matching lines @@
   runner->RunInstallWebApk();
   EXPECT_FALSE(runner->success());
 }
 
 // Test update succeeding.
 TEST_F(WebApkInstallerTest, UpdateSuccess) {
   std::unique_ptr<WebApkInstallerRunner> runner = CreateWebApkInstallerRunner();
   runner->RunUpdateWebApk();
   EXPECT_TRUE(runner->success());
 }