android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 226363004: Global GPU memory manager for android webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 226363004: Global GPU memory manager for android webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Bo's comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/shared_renderer_state.cc ('K') | « android_webview/browser/shared_renderer_state.cc ('k') | android_webview/native/aw_contents.h » ('j') | android_webview/native/aw_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index f6eaa03d8489672c89a226c1365aa98c6c420a89..aba9ea6956f2235018c4ae3f03aa2d707997b4eb 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -232,8 +232,6 @@ public class AwContents {

}

@Override

public void run() {

- // This is a no-op if not currently attached.

hush (inactive) 2014/05/01 19:03:04 this change will be gone after rebasing

- nativeOnDetachedFromWindow(mNativeAwContents);

nativeDestroy(mNativeAwContents);

}