Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fxge/ge/cfx_facecache.cpp

Issue 2263623002: Refactor fx_font part 3 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fxge/apple/fx_apple_platform.cpp ('k') | core/fxge/ge/cfx_fontcache.cpp » ('j') | core/fxge/include/cfx_facecache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fxge/ge/cfx_facecache.cpp
diff --git a/core/fxge/ge/cfx_facecache.cpp b/core/fxge/ge/cfx_facecache.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..efbc5acb427ed16a94b5ccc2d4892587d27ab093
--- /dev/null
+++ b/core/fxge/ge/cfx_facecache.cpp
@@ -0,0 +1,392 @@
+// Copyright 2016 PDFium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
+
+#include "core/fxge/include/cfx_facecache.h"
+
+#include "core/fxge/ge/fx_text_int.h"
+#include "core/fxge/include/cfx_fontmgr.h"
+#include "core/fxge/include/cfx_gemodule.h"
+#include "core/fxge/include/cfx_pathdata.h"
+#include "core/fxge/include/fx_freetype.h"
+
+#ifdef _SKIA_SUPPORT_
+#include "third_party/skia/include/core/SkStream.h"
+#include "third_party/skia/include/core/SkTypeface.h"
+#endif
+
+namespace {
+
+static void GammaAdjust(uint8_t* pData,
Lei Zhang 2016/08/19 18:24:46 No need for static inside anonymous namespace.
npm 2016/08/19 22:02:32 Done.
+ int nWid,
Lei Zhang 2016/08/19 18:24:46 Can we name these nWidth/nHeight?
Lei Zhang 2016/08/19 18:24:46 Maybe delete the unused parameters?
npm 2016/08/19 22:02:32 Done.
npm 2016/08/19 22:02:32 Done.
+ int nHei,
+ int src_pitch,
+ const uint8_t* gammaTable) {
+ int count = nHei * src_pitch;
+ for (int i = 0; i < count; i++)
+ pData[i] = gammaTable[pData[i]];
+}
+
+static void ContrastAdjust(uint8_t* pDataIn,
+ uint8_t* pDataOut,
+ int nWid,
+ int nHei,
+ int nSrcRowBytes,
+ int nDstRowBytes) {
+ int col, row, temp;
Lei Zhang 2016/08/19 18:24:46 1 decl per line
npm 2016/08/19 22:02:32 Done.
+ int max = 0, min = 255;
+ FX_FLOAT rate;
+ for (row = 0; row < nHei; row++) {
+ uint8_t* pRow = pDataIn + row * nSrcRowBytes;
+ for (col = 0; col < nWid; col++) {
+ temp = *pRow++;
+ if (temp > max)
Lei Zhang 2016/08/19 18:24:46 use std::min/max.
npm 2016/08/19 22:02:32 Done.
+ max = temp;
+ if (temp < min)
+ min = temp;
+ }
+ }
+ temp = max - min;
+ if (0 == temp || 255 == temp) {
Lei Zhang 2016/08/19 18:24:46 Flip to temp == 0
npm 2016/08/19 22:02:32 Done.
+ int rowbytes = FXSYS_abs(nSrcRowBytes) > nDstRowBytes
Lei Zhang 2016/08/19 18:24:46 std::min
npm 2016/08/19 22:02:32 Done.
+ ? nDstRowBytes
+ : FXSYS_abs(nSrcRowBytes);
+ for (row = 0; row < nHei; row++) {
+ FXSYS_memcpy(pDataOut + row * nDstRowBytes, pDataIn + row * nSrcRowBytes,
+ rowbytes);
+ }
+ return;
+ }
+ rate = 255.f / temp;
+ for (row = 0; row < nHei; row++) {
+ uint8_t* pSrcRow = pDataIn + row * nSrcRowBytes;
+ uint8_t* pDstRow = pDataOut + row * nDstRowBytes;
+ for (col = 0; col < nWid; col++) {
+ temp = (int)((*(pSrcRow++) - min) * rate + 0.5);
Lei Zhang 2016/08/19 18:24:46 Get rid of C-style casts.
npm 2016/08/19 22:02:32 Done.
+ if (temp > 255)
Lei Zhang 2016/08/19 18:24:46 More std::min/max
npm 2016/08/19 22:02:33 Done.
+ temp = 255;
+ else if (temp < 0)
+ temp = 0;
+ *pDstRow++ = (uint8_t)temp;
+ }
+ }
+}
+} // namespace
+
+CFX_FaceCache::CFX_FaceCache(FXFT_Face face)
+ : m_Face(face)
+#ifdef _SKIA_SUPPORT_
+ ,
+ m_pTypeface(nullptr)
+#endif
+{
+}
+
+CFX_FaceCache::~CFX_FaceCache() {
+ for (const auto& pair : m_SizeMap)
Lei Zhang 2016/08/19 18:24:46 Should |m_SizeMap| and |m_PathMap| hold std:unique
npm 2016/08/19 22:02:32 Done.
+ delete pair.second;
+ m_SizeMap.clear();
+ for (const auto& pair : m_PathMap)
+ delete pair.second;
+ m_PathMap.clear();
+#ifdef _SKIA_SUPPORT_
+ SkSafeUnref(m_pTypeface);
+#endif
+}
+
+CFX_GlyphBitmap* CFX_FaceCache::RenderGlyph(CFX_Font* pFont,
+ uint32_t glyph_index,
+ FX_BOOL bFontStyle,
+ const CFX_Matrix* pMatrix,
+ int dest_width,
+ int anti_alias) {
+ if (!m_Face)
+ return nullptr;
Lei Zhang 2016/08/19 18:24:46 blank line after
npm 2016/08/19 22:02:33 Done.
+ FXFT_Matrix ft_matrix;
+ ft_matrix.xx = (signed long)(pMatrix->GetA() / 64 * 65536);
+ ft_matrix.xy = (signed long)(pMatrix->GetC() / 64 * 65536);
+ ft_matrix.yx = (signed long)(pMatrix->GetB() / 64 * 65536);
+ ft_matrix.yy = (signed long)(pMatrix->GetD() / 64 * 65536);
+ FX_BOOL bUseCJKSubFont = FALSE;
Lei Zhang 2016/08/19 18:24:46 bool
npm 2016/08/19 22:02:32 Done.
+ const CFX_SubstFont* pSubstFont = pFont->GetSubstFont();
+ if (pSubstFont) {
+ bUseCJKSubFont = pSubstFont->m_bSubstCJK && bFontStyle;
+ int skew = 0;
+ if (bUseCJKSubFont)
+ skew = pSubstFont->m_bItalicCJK ? -15 : 0;
+ else
+ skew = pSubstFont->m_ItalicAngle;
+ if (skew) {
+ // |skew| is nonpositive so |-skew| is used as the index. We need to make
+ // sure |skew| != INT_MIN since -INT_MIN is undefined.
+ if (skew <= 0 && skew != std::numeric_limits<int>::min() &&
+ static_cast<size_t>(-skew) < CFX_Font::ANGLESKEW_ARRAY_SIZE) {
+ skew = -CFX_Font::g_AngleSkew[-skew];
+ } else {
+ skew = -58;
+ }
+ if (pFont->IsVertical())
+ ft_matrix.yx += ft_matrix.yy * skew / 100;
+ else
+ ft_matrix.xy -= ft_matrix.xx * skew / 100;
+ }
+ if (pSubstFont->m_SubstFlags & FXFONT_SUBST_MM) {
+ pFont->AdjustMMParams(glyph_index, dest_width,
+ pFont->GetSubstFont()->m_Weight);
+ }
+ }
+ ScopedFontTransform scoped_transform(m_Face, &ft_matrix);
+ int load_flags = (m_Face->face_flags & FT_FACE_FLAG_SFNT)
+ ? FXFT_LOAD_NO_BITMAP
+ : (FXFT_LOAD_NO_BITMAP | FT_LOAD_NO_HINTING);
+ int error = FXFT_Load_Glyph(m_Face, glyph_index, load_flags);
+ if (error) {
+ // if an error is returned, try to reload glyphs without hinting.
+ if (load_flags & FT_LOAD_NO_HINTING || load_flags & FT_LOAD_NO_SCALE)
+ return nullptr;
+
+ load_flags |= FT_LOAD_NO_HINTING;
+ error = FXFT_Load_Glyph(m_Face, glyph_index, load_flags);
+
+ if (error)
+ return nullptr;
+ }
+ int weight = 0;
+ if (bUseCJKSubFont)
+ weight = pSubstFont->m_WeightCJK;
+ else
+ weight = pSubstFont ? pSubstFont->m_Weight : 0;
+ if (pSubstFont && !(pSubstFont->m_SubstFlags & FXFONT_SUBST_MM) &&
+ weight > 400) {
+ uint32_t index = (weight - 400) / 10;
+ if (index >= CFX_Font::WEIGHTPOW_ARRAY_SIZE)
+ return nullptr;
+ int level = 0;
+ if (pSubstFont->m_Charset == FXFONT_SHIFTJIS_CHARSET) {
+ level =
+ CFX_Font::g_WeightPow_SHIFTJIS[index] * 2 *
+ (FXSYS_abs((int)(ft_matrix.xx)) + FXSYS_abs((int)(ft_matrix.xy))) /
+ 36655;
+ } else {
+ level =
+ CFX_Font::g_WeightPow_11[index] *
+ (FXSYS_abs((int)(ft_matrix.xx)) + FXSYS_abs((int)(ft_matrix.xy))) /
+ 36655;
+ }
+ FXFT_Outline_Embolden(FXFT_Get_Glyph_Outline(m_Face), level);
+ }
+ FXFT_Library_SetLcdFilter(CFX_GEModule::Get()->GetFontMgr()->GetFTLibrary(),
+ FT_LCD_FILTER_DEFAULT);
+ error = FXFT_Render_Glyph(m_Face, anti_alias);
+ if (error)
+ return nullptr;
+ int bmwidth = FXFT_Get_Bitmap_Width(FXFT_Get_Glyph_Bitmap(m_Face));
+ int bmheight = FXFT_Get_Bitmap_Rows(FXFT_Get_Glyph_Bitmap(m_Face));
+ if (bmwidth > 2048 || bmheight > 2048)
+ return nullptr;
+ int dib_width = bmwidth;
+ CFX_GlyphBitmap* pGlyphBitmap = new CFX_GlyphBitmap;
+ pGlyphBitmap->m_Bitmap.Create(
+ dib_width, bmheight,
+ anti_alias == FXFT_RENDER_MODE_MONO ? FXDIB_1bppMask : FXDIB_8bppMask);
+ pGlyphBitmap->m_Left = FXFT_Get_Glyph_BitmapLeft(m_Face);
+ pGlyphBitmap->m_Top = FXFT_Get_Glyph_BitmapTop(m_Face);
+ int dest_pitch = pGlyphBitmap->m_Bitmap.GetPitch();
+ int src_pitch = FXFT_Get_Bitmap_Pitch(FXFT_Get_Glyph_Bitmap(m_Face));
+ uint8_t* pDestBuf = pGlyphBitmap->m_Bitmap.GetBuffer();
+ uint8_t* pSrcBuf =
+ (uint8_t*)FXFT_Get_Bitmap_Buffer(FXFT_Get_Glyph_Bitmap(m_Face));
+ if (anti_alias != FXFT_RENDER_MODE_MONO &&
+ FXFT_Get_Bitmap_PixelMode(FXFT_Get_Glyph_Bitmap(m_Face)) ==
+ FXFT_PIXEL_MODE_MONO) {
+ int bytes = anti_alias == FXFT_RENDER_MODE_LCD ? 3 : 1;
+ for (int i = 0; i < bmheight; i++) {
+ for (int n = 0; n < bmwidth; n++) {
+ uint8_t data =
+ (pSrcBuf[i * src_pitch + n / 8] & (0x80 >> (n % 8))) ? 255 : 0;
+ for (int b = 0; b < bytes; b++)
+ pDestBuf[i * dest_pitch + n * bytes + b] = data;
+ }
+ }
+ } else {
+ FXSYS_memset(pDestBuf, 0, dest_pitch * bmheight);
+ if (anti_alias == FXFT_RENDER_MODE_MONO &&
+ FXFT_Get_Bitmap_PixelMode(FXFT_Get_Glyph_Bitmap(m_Face)) ==
+ FXFT_PIXEL_MODE_MONO) {
+ int rowbytes =
+ FXSYS_abs(src_pitch) > dest_pitch ? dest_pitch : FXSYS_abs(src_pitch);
+ for (int row = 0; row < bmheight; row++) {
+ FXSYS_memcpy(pDestBuf + row * dest_pitch, pSrcBuf + row * src_pitch,
+ rowbytes);
+ }
+ } else {
+ ContrastAdjust(pSrcBuf, pDestBuf, bmwidth, bmheight, src_pitch,
+ dest_pitch);
+ GammaAdjust(pDestBuf, bmwidth, bmheight, dest_pitch,
+ CFX_GEModule::Get()->GetTextGammaTable());
+ }
+ }
+ return pGlyphBitmap;
+}
+
+const CFX_PathData* CFX_FaceCache::LoadGlyphPath(CFX_Font* pFont,
+ uint32_t glyph_index,
+ int dest_width) {
+ if (!m_Face || glyph_index == (uint32_t)-1)
+ return nullptr;
+
+ uint32_t key = glyph_index;
+ if (pFont->GetSubstFont()) {
+ key += (((pFont->GetSubstFont()->m_Weight / 16) << 15) +
+ ((pFont->GetSubstFont()->m_ItalicAngle / 2) << 21) +
+ ((dest_width / 16) << 25) + (pFont->IsVertical() << 31));
+ }
+ auto it = m_PathMap.find(key);
+ if (it != m_PathMap.end())
+ return it->second;
+
+ CFX_PathData* pGlyphPath = pFont->LoadGlyphPath(glyph_index, dest_width);
+ m_PathMap[key] = pGlyphPath;
+ return pGlyphPath;
+}
+
+const CFX_GlyphBitmap* CFX_FaceCache::LoadGlyphBitmap(CFX_Font* pFont,
+ uint32_t glyph_index,
+ FX_BOOL bFontStyle,
+ const CFX_Matrix* pMatrix,
+ int dest_width,
+ int anti_alias,
+ int& text_flags) {
+ if (glyph_index == (uint32_t)-1)
+ return nullptr;
+ _CFX_UniqueKeyGen keygen;
+#if _FXM_PLATFORM_ != _FXM_PLATFORM_APPLE_
+ if (pFont->GetSubstFont())
+ keygen.Generate(9, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
Lei Zhang 2016/08/19 18:24:46 Let's calculate the matrix values just once...
npm 2016/08/19 22:02:32 Done.
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias, pFont->GetSubstFont()->m_Weight,
+ pFont->GetSubstFont()->m_ItalicAngle, pFont->IsVertical());
+ else
+ keygen.Generate(6, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias);
+#else
+ if (text_flags & FXTEXT_NO_NATIVETEXT) {
+ if (pFont->GetSubstFont())
+ keygen.Generate(9, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias, pFont->GetSubstFont()->m_Weight,
+ pFont->GetSubstFont()->m_ItalicAngle,
+ pFont->IsVertical());
+ else
+ keygen.Generate(6, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias);
+ } else {
+ if (pFont->GetSubstFont())
+ keygen.Generate(10, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias, pFont->GetSubstFont()->m_Weight,
+ pFont->GetSubstFont()->m_ItalicAngle, pFont->IsVertical(),
+ 3);
+ else
+ keygen.Generate(7, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias, 3);
+ }
+#endif
+ CFX_ByteString FaceGlyphsKey(keygen.m_Key, keygen.m_KeyLen);
+#if _FXM_PLATFORM_ != _FXM_PLATFORM_APPLE_ || defined _SKIA_SUPPORT_
+ return LookUpGlyphBitmap(pFont, pMatrix, FaceGlyphsKey, glyph_index,
+ bFontStyle, dest_width, anti_alias);
+#else
+ if (text_flags & FXTEXT_NO_NATIVETEXT) {
+ return LookUpGlyphBitmap(pFont, pMatrix, FaceGlyphsKey, glyph_index,
+ bFontStyle, dest_width, anti_alias);
+ }
+ CFX_GlyphBitmap* pGlyphBitmap;
+ auto it = m_SizeMap.find(FaceGlyphsKey);
+ if (it != m_SizeMap.end()) {
+ CFX_SizeGlyphCache* pSizeCache = it->second;
+ auto it2 = pSizeCache->m_GlyphMap.find(glyph_index);
+ if (it2 != pSizeCache->m_GlyphMap.end())
+ return it2->second;
+
+ pGlyphBitmap = RenderGlyph_Nativetext(pFont, glyph_index, pMatrix,
+ dest_width, anti_alias);
+ if (pGlyphBitmap) {
+ pSizeCache->m_GlyphMap[glyph_index] = pGlyphBitmap;
+ return pGlyphBitmap;
+ }
+ } else {
+ pGlyphBitmap = RenderGlyph_Nativetext(pFont, glyph_index, pMatrix,
+ dest_width, anti_alias);
+ if (pGlyphBitmap) {
+ CFX_SizeGlyphCache* pSizeCache = new CFX_SizeGlyphCache;
+ m_SizeMap[FaceGlyphsKey] = pSizeCache;
+ pSizeCache->m_GlyphMap[glyph_index] = pGlyphBitmap;
+ return pGlyphBitmap;
+ }
+ }
+ if (pFont->GetSubstFont())
+ keygen.Generate(9, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias, pFont->GetSubstFont()->m_Weight,
+ pFont->GetSubstFont()->m_ItalicAngle, pFont->IsVertical());
+ else
+ keygen.Generate(6, (int)(pMatrix->a * 10000), (int)(pMatrix->b * 10000),
+ (int)(pMatrix->c * 10000), (int)(pMatrix->d * 10000),
+ dest_width, anti_alias);
+ CFX_ByteString FaceGlyphsKey2(keygen.m_Key, keygen.m_KeyLen);
+ text_flags |= FXTEXT_NO_NATIVETEXT;
+ return LookUpGlyphBitmap(pFont, pMatrix, FaceGlyphsKey2, glyph_index,
+ bFontStyle, dest_width, anti_alias);
+#endif
+}
+
+#ifdef _SKIA_SUPPORT_
+CFX_TypeFace* CFX_FaceCache::GetDeviceCache(CFX_Font* pFont) {
+ if (!m_pTypeface) {
+ m_pTypeface =
+ SkTypeface::MakeFromStream(
+ new SkMemoryStream(pFont->GetFontData(), pFont->GetSize()))
+ .release();
+ }
+ return m_pTypeface;
+}
+#endif
+
+#if _FXM_PLATFORM_ != _FXM_PLATFORM_APPLE_
+void CFX_FaceCache::InitPlatform() {}
+#endif
+
+CFX_GlyphBitmap* CFX_FaceCache::LookUpGlyphBitmap(
+ CFX_Font* pFont,
+ const CFX_Matrix* pMatrix,
+ const CFX_ByteString& FaceGlyphsKey,
+ uint32_t glyph_index,
+ FX_BOOL bFontStyle,
+ int dest_width,
+ int anti_alias) {
+ CFX_SizeGlyphCache* pSizeCache;
+ auto it = m_SizeMap.find(FaceGlyphsKey);
+ if (it == m_SizeMap.end()) {
+ pSizeCache = new CFX_SizeGlyphCache;
+ m_SizeMap[FaceGlyphsKey] = pSizeCache;
+ } else {
+ pSizeCache = it->second;
+ }
+ auto it2 = pSizeCache->m_GlyphMap.find(glyph_index);
+ if (it2 != pSizeCache->m_GlyphMap.end())
+ return it2->second;
+
+ CFX_GlyphBitmap* pGlyphBitmap = RenderGlyph(pFont, glyph_index, bFontStyle,
+ pMatrix, dest_width, anti_alias);
+ if (!pGlyphBitmap)
+ return nullptr;
+
+ pSizeCache->m_GlyphMap[glyph_index] = pGlyphBitmap;
+ return pGlyphBitmap;
+}
« no previous file with comments | « core/fxge/apple/fx_apple_platform.cpp ('k') | core/fxge/ge/cfx_fontcache.cpp » ('j') | core/fxge/include/cfx_facecache.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698