Refactor fx_font part 3

Move CFX_FaceCache to its own file

Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class

Committed: https://pdfium.googlesource.com/pdfium/+/19ecc23e30f0d5368a703d751afd718a0c6434f6

[npm, 2016-08-19 17:26:22]

Description was changed from

==========
Move CFX_FaceCache to its own file

BUG=
==========

to

==========
Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class
==========

[npm, 2016-08-19 17:26:22]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-19 17:26:29]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-19 17:31:33]

Description was changed from

==========
Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class
==========

to

==========
Move CFX_FaceCache to its own file

Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class
==========

[npm, 2016-08-19 17:51:33]

PTAL

[commit-bot: I haz the power, 2016-08-19 18:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 18:04:45]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-19 18:24:46]

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache.cpp
File core/fxge/ge/cfx_facecache.cpp (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:22: static void GammaAdjust(uint8_t* pData,
No need for static inside anonymous namespace.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:23: int nWid,
Can we name these nWidth/nHeight?

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:23: int nWid,
Maybe delete the unused parameters?

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:38: int col, row, temp;
1 decl per line

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:45: if (temp > max)
use std::min/max.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:52: if (0 == temp || 255 == temp) {
Flip to temp == 0

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:53: int rowbytes = FXSYS_abs(nSrcRowBytes) >
nDstRowBytes
std::min

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:67: temp = (int)((*(pSrcRow++) - min) * rate +
0.5);
Get rid of C-style casts.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:68: if (temp > 255)
More std::min/max

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:88: for (const auto& pair : m_SizeMap)
Should |m_SizeMap| and |m_PathMap| hold std:unique_ptrs?

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:106: return nullptr;
blank line after

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:112: FX_BOOL bUseCJKSubFont = FALSE;
bool

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:267: keygen.Generate(9, (int)(pMatrix->a *
10000), (int)(pMatrix->b * 10000),
Let's calculate the matrix values just once...

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/cfx_facec...
File core/fxge/include/cfx_facecache.h (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/cfx_facec...
core/fxge/include/cfx_facecache.h:60: CFX_DIBitmap* m_pBitmap;
Is this used?

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h
File core/fxge/include/fx_font.h (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h...
core/fxge/include/fx_font.h:146: static const size_t ANGLESKEW_ARRAY_SIZE = 30;
kConstFoo

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h...
core/fxge/include/fx_font.h:147: static const char
g_AngleSkew[ANGLESKEW_ARRAY_SIZE];
no longer global -> s_ prefix?

[npm, 2016-08-19 22:02:16]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 22:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-19 22:02:33]

PTAL

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache.cpp
File core/fxge/ge/cfx_facecache.cpp (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:22: static void GammaAdjust(uint8_t* pData,
On 2016/08/19 18:24:46, Lei Zhang wrote:
> No need for static inside anonymous namespace.

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:23: int nWid,
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Can we name these nWidth/nHeight?

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:23: int nWid,
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Maybe delete the unused parameters?

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:38: int col, row, temp;
On 2016/08/19 18:24:46, Lei Zhang wrote:
> 1 decl per line

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:45: if (temp > max)
On 2016/08/19 18:24:46, Lei Zhang wrote:
> use std::min/max.

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:52: if (0 == temp || 255 == temp) {
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Flip to temp == 0

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:53: int rowbytes = FXSYS_abs(nSrcRowBytes) >
nDstRowBytes
On 2016/08/19 18:24:46, Lei Zhang wrote:
> std::min

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:67: temp = (int)((*(pSrcRow++) - min) * rate +
0.5);
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Get rid of C-style casts.

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:68: if (temp > 255)
On 2016/08/19 18:24:46, Lei Zhang wrote:
> More std::min/max

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:88: for (const auto& pair : m_SizeMap)
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Should |m_SizeMap| and |m_PathMap| hold std:unique_ptrs?

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:106: return nullptr;
On 2016/08/19 18:24:46, Lei Zhang wrote:
> blank line after

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:112: FX_BOOL bUseCJKSubFont = FALSE;
On 2016/08/19 18:24:46, Lei Zhang wrote:
> bool

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/ge/cfx_facecache....
core/fxge/ge/cfx_facecache.cpp:267: keygen.Generate(9, (int)(pMatrix->a *
10000), (int)(pMatrix->b * 10000),
On 2016/08/19 18:24:46, Lei Zhang wrote:
> Let's calculate the matrix values just once...

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/cfx_facec...
File core/fxge/include/cfx_facecache.h (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/cfx_facec...
core/fxge/include/cfx_facecache.h:60: CFX_DIBitmap* m_pBitmap;
Apparently not

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h
File core/fxge/include/fx_font.h (right):

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h...
core/fxge/include/fx_font.h:146: static const size_t ANGLESKEW_ARRAY_SIZE = 30;
On 2016/08/19 18:24:46, Lei Zhang wrote:
> kConstFoo

Done.

https://codereview.chromium.org/2263623002/diff/1/core/fxge/include/fx_font.h...
core/fxge/include/fx_font.h:147: static const char
g_AngleSkew[ANGLESKEW_ARRAY_SIZE];
On 2016/08/19 18:24:46, Lei Zhang wrote:
> no longer global -> s_ prefix?

Done.

[commit-bot: I haz the power, 2016-08-19 22:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:04:53]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[npm, 2016-08-19 22:17:02]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 22:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 22:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 22:35:01]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-19 22:44:58]

lgtm

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/cfx_faceca...
File core/fxge/ge/cfx_facecache.cpp (right):

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/cfx_faceca...
core/fxge/ge/cfx_facecache.cpp:102: bool bUseCJKSubFont = FALSE;
s/FALSE/false/

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/cfx_faceca...
core/fxge/ge/cfx_facecache.cpp:255: int pMatrixA = static_cast<int>(pMatrix->a *
10000);
|nMatrixA| because it's not a pointer?

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/cfx_faceca...
core/fxge/ge/cfx_facecache.cpp:260: if (pFont->GetSubstFont())
braces braces braces

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/cfx_faceca...
core/fxge/ge/cfx_facecache.cpp:322: if (pFont->GetSubstFont())
braces

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/fx_ge_text...
File core/fxge/ge/fx_ge_text.cpp (right):

https://codereview.chromium.org/2263623002/diff/50001/core/fxge/ge/fx_ge_text...
core/fxge/ge/fx_ge_text.cpp:340: if (index >= kWeightPowArraySize)
std::min(index, kWeightPowArraySize - 1)

[npm, 2016-08-19 23:04:55]

The CQ bit was checked by npm@chromium.org

[npm, 2016-08-19 23:04:56]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2263623002/#ps70001
(title: "Comments")

[commit-bot: I haz the power, 2016-08-19 23:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 23:17:59]

Description was changed from

==========
Move CFX_FaceCache to its own file

Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class
==========

to

==========
Move CFX_FaceCache to its own file

Moved ScopedFontTransform from fx_ge_text namespace to fx_font
Moved some arrays used by both CFX_Font and CFX_FaceCache from fx_ge_text to
inside CFX_Font class

Committed:
https://pdfium.googlesource.com/pdfium/+/19ecc23e30f0d5368a703d751afd718a0c64...
==========

[commit-bot: I haz the power, 2016-08-19 23:18:00]

Committed patchset #5 (id:70001) as
https://pdfium.googlesource.com/pdfium/+/19ecc23e30f0d5368a703d751afd718a0c64...