Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/builtins/arm/builtins-arm.cc

Issue 2263533002: [builtins] Migrate DatePrototype_GetField to TurboFan builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix C call return type Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/arm/builtins-arm.cc
diff --git a/src/builtins/arm/builtins-arm.cc b/src/builtins/arm/builtins-arm.cc
index e43ccc738a2e0558e949edbccfbb023ce815c237..26c6023da9e7fd8e24b07fde47ceb41a412ec952 100644
--- a/src/builtins/arm/builtins-arm.cc
+++ b/src/builtins/arm/builtins-arm.cc
@@ -1867,71 +1867,6 @@ void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) {
}
// static
-void Builtins::Generate_DatePrototype_GetField(MacroAssembler* masm,
- int field_index) {
- // ----------- S t a t e -------------
- // -- r0 : number of arguments
- // -- r1 : function
- // -- cp : context
- // -- lr : return address
- // -- sp[0] : receiver
- // -----------------------------------
-
- // 1. Pop receiver into r0 and check that it's actually a JSDate object.
- Label receiver_not_date;
- {
- __ Pop(r0);
- __ JumpIfSmi(r0, &receiver_not_date);
- __ CompareObjectType(r0, r2, r3, JS_DATE_TYPE);
- __ b(ne, &receiver_not_date);
- }
-
- // 2. Load the specified date field, falling back to the runtime as necessary.
- if (field_index == JSDate::kDateValue) {
- __ ldr(r0, FieldMemOperand(r0, JSDate::kValueOffset));
- } else {
- if (field_index < JSDate::kFirstUncachedField) {
- Label stamp_mismatch;
- __ mov(r1, Operand(ExternalReference::date_cache_stamp(masm->isolate())));
- __ ldr(r1, MemOperand(r1));
- __ ldr(ip, FieldMemOperand(r0, JSDate::kCacheStampOffset));
- __ cmp(r1, ip);
- __ b(ne, &stamp_mismatch);
- __ ldr(r0, FieldMemOperand(
- r0, JSDate::kValueOffset + field_index * kPointerSize));
- __ Ret();
- __ bind(&stamp_mismatch);
- }
- FrameScope scope(masm, StackFrame::INTERNAL);
- __ PrepareCallCFunction(2, r1);
- __ mov(r1, Operand(Smi::FromInt(field_index)));
- __ CallCFunction(
- ExternalReference::get_date_field_function(masm->isolate()), 2);
- }
- __ Ret();
-
- // 3. Raise a TypeError if the receiver is not a date.
- __ bind(&receiver_not_date);
- {
- FrameScope scope(masm, StackFrame::MANUAL);
- __ Push(r0);
- __ Move(r0, Smi::FromInt(0));
- __ EnterBuiltinFrame(cp, r1, r0);
- __ CallRuntime(Runtime::kThrowNotDateError);
-
- // It's far from obvious, but this final trailing instruction after the call
- // is required for StackFrame::LookupCode to work correctly. To illustrate
- // why: if call were the final instruction in the code object, then the pc
- // (== return address) would point beyond the code object when the stack is
- // traversed. When we then try to look up the code object through
- // StackFrame::LookupCode, we actually return the next code object that
- // happens to be on the same page in memory.
- // TODO(jgruber): A proper fix for this would be nice.
- __ nop();
- }
-}
-
-// static
void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
// ----------- S t a t e -------------
// -- r0 : argc
« no previous file with comments | « no previous file | src/builtins/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698