Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/builtins/x64/builtins-x64.cc

Issue 2263533002: [builtins] Migrate DatePrototype_GetField to TurboFan builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Directly call to C++ instead of runtime. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/x64/builtins-x64.cc
diff --git a/src/builtins/x64/builtins-x64.cc b/src/builtins/x64/builtins-x64.cc
index 028a0f327b7ca182a29af7ba8febfb41a8e2750d..1062406d963a1c2ae8619dd73c5e5a6c1fcb9a25 100644
--- a/src/builtins/x64/builtins-x64.cc
+++ b/src/builtins/x64/builtins-x64.cc
@@ -1297,70 +1297,6 @@ void Builtins::Generate_NotifyLazyDeoptimized(MacroAssembler* masm) {
}
// static
-void Builtins::Generate_DatePrototype_GetField(MacroAssembler* masm,
- int field_index) {
- // ----------- S t a t e -------------
- // -- rax : number of arguments
- // -- rdi : function
- // -- rsi : context
- // -- rsp[0] : return address
- // -- rsp[8] : receiver
- // -----------------------------------
-
- // 1. Load receiver into rax and check that it's actually a JSDate object.
- Label receiver_not_date;
- {
- StackArgumentsAccessor args(rsp, 0);
- __ movp(rax, args.GetReceiverOperand());
- __ JumpIfSmi(rax, &receiver_not_date);
- __ CmpObjectType(rax, JS_DATE_TYPE, rbx);
- __ j(not_equal, &receiver_not_date);
- }
-
- // 2. Load the specified date field, falling back to the runtime as necessary.
- if (field_index == JSDate::kDateValue) {
- __ movp(rax, FieldOperand(rax, JSDate::kValueOffset));
- } else {
- if (field_index < JSDate::kFirstUncachedField) {
- Label stamp_mismatch;
- __ Load(rdx, ExternalReference::date_cache_stamp(masm->isolate()));
- __ cmpp(rdx, FieldOperand(rax, JSDate::kCacheStampOffset));
- __ j(not_equal, &stamp_mismatch, Label::kNear);
- __ movp(rax, FieldOperand(
- rax, JSDate::kValueOffset + field_index * kPointerSize));
- __ ret(1 * kPointerSize);
- __ bind(&stamp_mismatch);
- }
- FrameScope scope(masm, StackFrame::INTERNAL);
- __ PrepareCallCFunction(2);
- __ Move(arg_reg_1, rax);
- __ Move(arg_reg_2, Smi::FromInt(field_index));
- __ CallCFunction(
- ExternalReference::get_date_field_function(masm->isolate()), 2);
- }
- __ ret(1 * kPointerSize);
-
- // 3. Raise a TypeError if the receiver is not a date.
- __ bind(&receiver_not_date);
- {
- FrameScope scope(masm, StackFrame::MANUAL);
- __ Move(rbx, Smi::FromInt(0));
- __ EnterBuiltinFrame(rsi, rdi, rbx);
- __ CallRuntime(Runtime::kThrowNotDateError);
-
- // It's far from obvious, but this final trailing instruction after the call
- // is required for StackFrame::LookupCode to work correctly. To illustrate
- // why: if call were the final instruction in the code object, then the pc
- // (== return address) would point beyond the code object when the stack is
- // traversed. When we then try to look up the code object through
- // StackFrame::LookupCode, we actually return the next code object that
- // happens to be on the same page in memory.
- // TODO(jgruber): A proper fix for this would be nice.
- __ int3();
- }
-}
-
-// static
void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
// ----------- S t a t e -------------
// -- rax : argc

Powered by Google App Engine
This is Rietveld 408576698