[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
Committed: https://crrev.com/62e02829e15f4b920d9b89c28be077cbeadae947
Cr-Commit-Position: refs/heads/master@{#39438}

[alegil02, 2016-08-19 09:21:18]

Description was changed from

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
==========

to

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
==========

[alegil02, 2016-08-19 09:21:18]

alexander.gilday2@arm.com changed reviewers:
+ bmeurer@chromium.org, hpayer@chromium.org

[Benedikt Meurer, 2016-08-19 16:25:19]

https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date.cc
File src/builtins/builtins-date.cc (right):

https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date....
src/builtins/builtins-date.cc:936: Node* date_cache_stamp =
assembler->ExternalConstant(
You need to load the value of the stamp via the external reference.

[alegil02, 2016-09-01 14:47:04]

On 2016/08/19 16:25:19, Benedikt Meurer wrote:
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date.cc
> File src/builtins/builtins-date.cc (right):
> 
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date....
> src/builtins/builtins-date.cc:936: Node* date_cache_stamp =
> assembler->ExternalConstant(
> You need to load the value of the stamp via the external reference.

I have made the appropriate changes, PTAL.

[alegil02, 2016-09-01 14:49:20]

On 2016/09/01 14:47:04, alegil02 wrote:
> On 2016/08/19 16:25:19, Benedikt Meurer wrote:
> >
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date.cc
> > File src/builtins/builtins-date.cc (right):
> > 
> >
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date....
> > src/builtins/builtins-date.cc:936: Node* date_cache_stamp =
> > assembler->ExternalConstant(
> > You need to load the value of the stamp via the external reference.
> 
> I have made the appropriate changes, PTAL.

Sorry for the extra message but there was a recent patch which fixed an issue in
the original builting (https://codereview.chromium.org/2284673002). Should I be
worried about it?

[Benedikt Meurer, 2016-09-02 04:29:45]

bmeurer@chromium.org changed reviewers:
- hpayer@chromium.org

[Benedikt Meurer, 2016-09-02 04:30:34]

On 2016/09/01 14:49:20, alegil02 wrote:
> On 2016/09/01 14:47:04, alegil02 wrote:
> > On 2016/08/19 16:25:19, Benedikt Meurer wrote:
> > >
> >
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date.cc
> > > File src/builtins/builtins-date.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2263533002/diff/1/src/builtins/builtins-date....
> > > src/builtins/builtins-date.cc:936: Node* date_cache_stamp =
> > > assembler->ExternalConstant(
> > > You need to load the value of the stamp via the external reference.
> > 
> > I have made the appropriate changes, PTAL.
> 
> Sorry for the extra message but there was a recent patch which fixed an issue
in
> the original builting (https://codereview.chromium.org/2284673002). Should I
be
> worried about it?

Nope that shouldn't affect the TF version.

[Benedikt Meurer, 2016-09-02 04:33:49]

https://codereview.chromium.org/2263533002/diff/20001/src/builtins/builtins-d...
File src/builtins/builtins-date.cc (right):

https://codereview.chromium.org/2263533002/diff/20001/src/builtins/builtins-d...
src/builtins/builtins-date.cc:952: Node* result =
assembler->CallRuntime(Runtime::kDateGetField, context,
This is (maybe way) more expensive than native version, which just called
directly to the C++ function, and would probably even remove the benefit of
having these builtins in TF (vs having them in C++). But using the simplified C
call descriptor, you should be able to also call directly into the C++ function
without going through the runtime entry first. For example the wasm-compiler
does this for various c calls.

[alegil02, 2016-09-09 08:10:45]

On 2016/09/02 04:33:49, Benedikt Meurer wrote:
>
https://codereview.chromium.org/2263533002/diff/20001/src/builtins/builtins-d...
> File src/builtins/builtins-date.cc (right):
> 
>
https://codereview.chromium.org/2263533002/diff/20001/src/builtins/builtins-d...
> src/builtins/builtins-date.cc:952: Node* result =
> assembler->CallRuntime(Runtime::kDateGetField, context,
> This is (maybe way) more expensive than native version, which just called
> directly to the C++ function, and would probably even remove the benefit of
> having these builtins in TF (vs having them in C++). But using the simplified
C
> call descriptor, you should be able to also call directly into the C++
function
> without going through the runtime entry first. For example the wasm-compiler
> does this for various c calls.

I exposed a function from raw_machine_assembler which calls directly to C++.
PTAL.

[Benedikt Meurer, 2016-09-13 17:14:50]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:14:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-13 17:17:07]

https://codereview.chromium.org/2263533002/diff/40001/src/builtins/builtins-d...
File src/builtins/builtins-date.cc (right):

https://codereview.chromium.org/2263533002/diff/40001/src/builtins/builtins-d...
src/builtins/builtins-date.cc:955: MachineType::Int32(), MachineType::Pointer(),
MachineType::AnyTagged(),
The result of this call is a tagged value.

[commit-bot: I haz the power, 2016-09-13 18:03:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:03:22]

Dry run: Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12600)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Benedikt Meurer, 2016-09-14 18:21:40]

LGTM, thanks.

[Benedikt Meurer, 2016-09-14 18:21:47]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 18:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:55:28]

Dry run: This issue passed the CQ dry run.

[alegil02, 2016-09-15 08:17:35]

The CQ bit was checked by alexander.gilday2@arm.com

[commit-bot: I haz the power, 2016-09-15 08:17:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 08:20:06]

Description was changed from

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
==========

to

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
==========

[commit-bot: I haz the power, 2016-09-15 08:20:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 08:20:26]

Description was changed from

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049
==========

to

==========
[builtins] Migrate DatePrototype_GetField to TurboFan builtin.

Migrate the platform DatePrototype_GetField (and all wrappers) to
TurboFan.

BUG=v8:5049

Committed: https://crrev.com/62e02829e15f4b920d9b89c28be077cbeadae947
Cr-Commit-Position: refs/heads/master@{#39438}
==========

[commit-bot: I haz the power, 2016-09-15 08:20:27]

Patchset 4 (id:??) landed as
https://crrev.com/62e02829e15f4b920d9b89c28be077cbeadae947
Cr-Commit-Position: refs/heads/master@{#39438}