Issue 226353003: Mojo: Move mojo/public/data/bindings/tests/ to mojo/public/interfaces/bindings/tests/data/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226353003: Mojo: Move mojo/public/data/bindings/tests/ to mojo/public/interfaces/bindings/tests/data/. (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Move mojo/public/data/bindings/tests/ to mojo/public/interfaces/bindings/tests/data/. It's slightly odd to have the test data under interfaces/, but only in the same way that it's odd to have bindings/ under interfaces/. (But everything looks odd in one way or another.) The rationale is that probably we'll want .mojom files describing test messages as well, and those would go under interfaces/bindings/tests/. And the language-specific tests would go under, e.g., cpp/bindings/tests/. This keeps the dependencies looking more sane. R=sky@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261905

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, -24 lines)			Patch
	D	mojo/public/data/bindings/tests/message_data	View		1 chunk	+0 lines, -25 lines	0 comments	Download
	A +	mojo/public/interfaces/bindings/tests/data/message_data	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/226353003/1

6 years, 8 months ago (2014-04-04 22:39:25 UTC) #4

Message was sent while issue was closed.

Change committed as 261905

Expand Messages | Collapse Messages