Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226353002: Remove unused input_shlib_path (Closed)

Created:
6 years, 8 months ago by cjhopman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, haitaol+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, agl, android-webview-reviews_chromium.org, jln+watch_chromium.org, maniscalco+watch_chromium.org, tfarina
Visibility:
Public.

Description

Remove unused input_shlib_path This path is now only inferred from test_suite_name. TBR=darin NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264666

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc_tests.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M media/media.gyp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M net/net.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M sql/sql.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sync_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/leveldatabase/leveldatabase.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/ui_unittests.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webkit/renderer/compositor_bindings/compositor_bindings_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
cjhopman
thakis: *
6 years, 8 months ago (2014-04-04 18:27:47 UTC) #1
Nico
enthusiastic lgtm with comment addressed! (clicking "raw diff" in rietveld is usually a good way ...
6 years, 8 months ago (2014-04-04 18:32:25 UTC) #2
cjhopman
https://codereview.chromium.org/226353002/diff/1/sandbox/linux/sandbox_linux.gypi File sandbox/linux/sandbox_linux.gypi (right): https://codereview.chromium.org/226353002/diff/1/sandbox/linux/sandbox_linux.gypi#newcode285 sandbox/linux/sandbox_linux.gypi:285: '<(SHARED_LIB_SUFFIX)', On 2014/04/04 18:32:25, Nico wrote: > Remove the ...
6 years, 8 months ago (2014-04-04 18:52:39 UTC) #3
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 8 months ago (2014-04-04 19:45:55 UTC) #4
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 8 months ago (2014-04-04 19:45:58 UTC) #5
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 8 months ago (2014-04-17 18:00:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/226353002/40001
6 years, 8 months ago (2014-04-17 18:02:00 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 18:53:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=62082
6 years, 8 months ago (2014-04-17 18:53:35 UTC) #9
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-17 18:56:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/226353002/40001
6 years, 8 months ago (2014-04-17 18:57:25 UTC) #11
cjhopman
TBR darin@chromium.org for *
6 years, 8 months ago (2014-04-17 19:01:58 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 23:12:36 UTC) #13
commit-bot: I haz the power
List of reviewers changed. darin@chromium.org did a drive-by without LGTM'ing!
6 years, 8 months ago (2014-04-17 23:12:37 UTC) #14
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-17 23:14:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/226353002/40001
6 years, 8 months ago (2014-04-17 23:15:04 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 23:17:00 UTC) #17
Message was sent while issue was closed. 
Change committed as 264666

Powered by Google App Engine
This is Rietveld 408576698