Add some scope-related DCHECKs.

Add some scope-related DCHECKs.

R=adamk@chromium.org, verwaest@chromium.org
BUG=

Committed: https://crrev.com/9bc44ff086af90fa45d7d7d00e295f4643503650
Cr-Commit-Position: refs/heads/master@{#38755}

[Toon Verwaest, 2016-08-19 12:48:53]

nice, lgtm with some nits

https://codereview.chromium.org/2263523002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2263523002/diff/1/src/ast/scopes.cc#newcode257
src/ast/scopes.cc:257: DCHECK(scope_info->scope_type() == SCRIPT_SCOPE);
DCHECK_EQ

https://codereview.chromium.org/2263523002/diff/1/src/ast/scopes.cc#newcode274
src/ast/scopes.cc:274: DCHECK(scope_info->scope_type() == BLOCK_SCOPE);
DCHECK_EQ

https://codereview.chromium.org/2263523002/diff/1/src/ast/variables.h
File src/ast/variables.h (right):

https://codereview.chromium.org/2263523002/diff/1/src/ast/variables.h#newcode46
src/ast/variables.h:46: DCHECK(IsUnallocated() || IsContextSlot());
This is surprising. I'd hope we wouldn't call ForceContextAllocation on already
allocated variables. I'm fine with cleaning this up in another CL, but I think
that should be an invariant ...

https://codereview.chromium.org/2263523002/diff/1/src/ast/variables.h#newcode100
src/ast/variables.h:100: DCHECK(IsUnallocated() || (location_ == location &&
index_ == index));
Same here...

https://codereview.chromium.org/2263523002/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2263523002/diff/1/src/factory.cc#newcode763
src/factory.cc:763: DCHECK(scope_info->scope_type() == SCRIPT_SCOPE);
_EQ

https://codereview.chromium.org/2263523002/diff/1/src/factory.cc#newcode788
src/factory.cc:788: DCHECK(scope_info->scope_type() == MODULE_SCOPE);
_EQ

https://codereview.chromium.org/2263523002/diff/1/src/factory.cc#newcode801
src/factory.cc:801: DCHECK(function->shared()->scope_info()->scope_type() ==
FUNCTION_SCOPE);
_EQ

https://codereview.chromium.org/2263523002/diff/1/src/factory.cc#newcode864
src/factory.cc:864: DCHECK(scope_info->scope_type() == BLOCK_SCOPE);
_EQ

[neis, 2016-08-19 13:33:27]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-19 13:33:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2263523002/#ps20001
(title: "DCHECK_EQ")

[commit-bot: I haz the power, 2016-08-19 13:33:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 13:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 13:34:45]

Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11237)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/11231)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22141)

[neis, 2016-08-19 13:42:18]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-19 13:42:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2263523002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-19 13:42:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 14:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 14:02:48]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[neis, 2016-08-19 14:18:30]

The CQ bit was checked by neis@chromium.org

[neis, 2016-08-19 14:18:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2263523002/#ps60001
(title: "Disable test262 module tests.")

[commit-bot: I haz the power, 2016-08-19 14:18:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 15:24:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 15:24:21]

Description was changed from

==========
Add some scope-related DCHECKs.

R=adamk@chromium.org, verwaest@chromium.org
BUG=
==========

to

==========
Add some scope-related DCHECKs.

R=adamk@chromium.org, verwaest@chromium.org
BUG=

Committed: https://crrev.com/9bc44ff086af90fa45d7d7d00e295f4643503650
Cr-Commit-Position: refs/heads/master@{#38755}
==========

[commit-bot: I haz the power, 2016-08-19 15:24:23]

Patchset 4 (id:??) landed as
https://crrev.com/9bc44ff086af90fa45d7d7d00e295f4643503650
Cr-Commit-Position: refs/heads/master@{#38755}