Fix bug, always keep fIsScaleTranslate in correct state

tests/QuickRejectTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCanvas.h"
 #include "SkDrawLooper.h"
+#include "SkLightingImageFilter.h"
 #include "SkTypes.h"
 #include "Test.h"
 
 /*
  *  Subclass of looper that just draws once, with an offset in X.
  */
 class TestLooper : public SkDrawLooper {
 public:
 
     SkDrawLooper::Context* createContext(SkCanvas*, void* storage) const override {
@@ skipping 118 matching lines @@
     REPORTER_ASSERT(reporter, false == canvas.quickReject(r11));
     REPORTER_ASSERT(reporter, true == canvas.quickReject(r12));
     REPORTER_ASSERT(reporter, true == canvas.quickReject(r13));
 }
 
 DEF_TEST(QuickReject, reporter) {
     test_drawBitmap(reporter);
     test_layers(reporter);
     test_quick_reject(reporter);
 }
+
+// Regression test to make sure that we keep fIsScaleTranslate up to date on the canvas.

[tomhudson, 2016/08/19 15:09:03]

Presumably the point is that sometimes we set a matrix without going through
setMatrix(), and this tests that path? (one of those paths?)

[msarett, 2016/08/19 15:15:31]

Yes, updating comment.

+DEF_TEST(QuickReject_MatrixState, reporter) {
+    SkCanvas canvas(100, 100);
+
+    // Set rotation matrix.

[tomhudson, 2016/08/19 15:09:03]

Nit: this is not a useful comment?

[msarett, 2016/08/19 15:15:31]

Removed.

+    SkMatrix matrix;
+    matrix.setRotate(45.0f);
+    canvas.setMatrix(matrix);
+
+    // Set image filter.

[tomhudson, 2016/08/19 15:09:03]

Nit: nor is this.

[msarett, 2016/08/19 15:15:31]

Removed.

+    SkPaint paint;
+    sk_sp<SkImageFilter> filter = SkLightingImageFilter::MakeDistantLitDiffuse(
+            SkPoint3::Make(1.0f, 1.0f, 1.0f), 0xFF0000FF, 2.0f, 0.5f, nullptr);
+    REPORTER_ASSERT(reporter, filter);
+    paint.setImageFilter(filter);
+    SkCanvas::SaveLayerRec rec;
+    rec.fPaint = &paint;
+    canvas.saveLayer(rec);
+
+    // Call quickReject().  It will assert if the matrix is out of sync.

[tomhudson, 2016/08/19 15:09:03]

// quickReject() will assert if the matrix is out of sync.

[msarett, 2016/08/19 15:15:31]

Done.

+    canvas.quickReject(SkRect::MakeWH(100.0f, 100.0f));
+}