Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 2263513002: Document CDB dependency in Windows build for external contributors. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document CDB dependency in Windows build for external contributors. The Windows 10 SDK installed by Visual Studio 2015 Community Edition does not include Debugging Tools for Windows. The build process requires CDB. According to the MSDN page on Debugging Tools, they are also bundled with the Windows Driver Kit, which is freely available. So, we can point our external contributors to the WDK to get CDB. BUG=639212 Committed: https://crrev.com/43b43ba9d4873b8ab11d1848ceb5ebd9befcf1c8 Cr-Commit-Position: refs/heads/master@{#413506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M docs/windows_build_instructions.md View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pwnall
Can you please take a look at this doc fix?
4 years, 4 months ago (2016-08-19 07:39:09 UTC) #2
brettw
lgtm
4 years, 4 months ago (2016-08-22 17:52:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263513002/1
4 years, 4 months ago (2016-08-22 18:33:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 19:29:45 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 19:32:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43b43ba9d4873b8ab11d1848ceb5ebd9befcf1c8
Cr-Commit-Position: refs/heads/master@{#413506}

Powered by Google App Engine
This is Rietveld 408576698