Make running the outdated build detector conditional on a Feature.

Make running the outdated build detector conditional on a Feature.

BUG=623986
R=thakis@chromium.org

Committed: https://crrev.com/fdcb4e332e0a63d73ee5437f0132fb8811e8e396
Cr-Commit-Position: refs/heads/master@{#413446}

[grt (UTC plus 2), 2016-08-19 07:06:26]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 07:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 07:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 07:48:42]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-08-22 14:23:37]

lgtm

[Nico, 2016-08-22 14:26:18]

lgtm

[grt (UTC plus 2), 2016-08-22 14:38:24]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-08-22 14:45:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 15:45:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 15:47:02]

Description was changed from

==========
Make running the outdated build detector conditional on a Feature.

BUG=623986
R=thakis@chromium.org
==========

to

==========
Make running the outdated build detector conditional on a Feature.

BUG=623986
R=thakis@chromium.org

Committed: https://crrev.com/fdcb4e332e0a63d73ee5437f0132fb8811e8e396
Cr-Commit-Position: refs/heads/master@{#413446}
==========

[commit-bot: I haz the power, 2016-08-22 15:47:03]

Patchset 1 (id:??) landed as
https://crrev.com/fdcb4e332e0a63d73ee5437f0132fb8811e8e396
Cr-Commit-Position: refs/heads/master@{#413446}

[grt (UTC plus 2), 2016-08-23 08:54:44]

Question for you, sir.

https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
File chrome/browser/upgrade_detector_impl.cc (right):

https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
chrome/browser/upgrade_detector_impl.cc:397: constexpr base::Feature
kOutdatedBuildDetector =
thakis: should this really be:
  static constexpr base::Feature ...
so that the struct isn't put on the stack in each invocation?

[merkin, 2017-03-07 10:35:43]

On 2016/08/23 08:54:44, grt (UTC plus 1) wrote:
> Question for you, sir.
> 
>
https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
> File chrome/browser/upgrade_detector_impl.cc (right):
> 
>
https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
> chrome/browser/upgrade_detector_impl.cc:397: constexpr base::Feature
> kOutdatedBuildDetector =
> thakis: should this really be:
>   static constexpr base::Feature ...
> so that the struct isn't put on the stack in each invocation?

Hello gentlemen!
YES it shall be static. I've just caught DCHECK failure.

[merkin, 2017-03-07 11:25:13]

On 2017/03/07 10:35:43, merkin wrote:
> On 2016/08/23 08:54:44, grt (UTC plus 1) wrote:
> > Question for you, sir.
> > 
> >
>
https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
> > File chrome/browser/upgrade_detector_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/2263503002/diff/1/chrome/browser/upgrade_dete...
> > chrome/browser/upgrade_detector_impl.cc:397: constexpr base::Feature
> > kOutdatedBuildDetector =
> > thakis: should this really be:
> >   static constexpr base::Feature ...
> > so that the struct isn't put on the stack in each invocation?
> 
> Hello gentlemen!
> YES it shall be static. I've just caught DCHECK failure.

Created a new patch: https://codereview.chromium.org/2736723005/