Don't create ScopeInfo if there already is one.

Don't create ScopeInfo if there already is one.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=

Committed: https://crrev.com/e6df4d74117dc57069fa28e3cfceb10c9e6be6ce
Cr-Commit-Position: refs/heads/master@{#38741}

[neis, 2016-08-19 06:49:24]

PTAL. I noticed that we create scope infos for scopes that already have them
(not sure if this happens most of the time or only sometimes). Maybe this is a
consequence of Ross's recent change to ast-numbering?

My change is minimal but it doesn't prevent the same problem from happening
again because anyone can call ScopeInfo::Create. I'm wondering if we should make
that function check the scope first or maybe encapsulate the ScopeInfo::Create
logic inside Scope. Let me know what you think.

[Michael Starzinger, 2016-08-19 07:56:26]

LGTM.

[rmcilroy, 2016-08-19 08:00:36]

lgtm

[neis, 2016-08-19 08:04:12]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-08-19 08:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 08:26:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-19 08:27:08]

Description was changed from

==========
Don't create ScopeInfo if there already is one.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=
==========

to

==========
Don't create ScopeInfo if there already is one.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=

Committed: https://crrev.com/e6df4d74117dc57069fa28e3cfceb10c9e6be6ce
Cr-Commit-Position: refs/heads/master@{#38741}
==========

[commit-bot: I haz the power, 2016-08-19 08:27:09]

Patchset 1 (id:??) landed as
https://crrev.com/e6df4d74117dc57069fa28e3cfceb10c9e6be6ce
Cr-Commit-Position: refs/heads/master@{#38741}