Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js

Issue 22634008: Add histgrams to Folder shortcut feature in Files.app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/navigation_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js
diff --git a/chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js b/chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js
index 25895f93f608a35a20bb476a5aa218b20ac9d600..e4855f6e01a99d123173946ff9438afb17a16d1a 100644
--- a/chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js
+++ b/chrome/browser/resources/file_manager/js/folder_shortcuts_data_model.js
@@ -35,6 +35,9 @@ function FolderShortcutsDataModel() {
if (list instanceof Array) {
list = filter(list);
+ // Record metrics.
+ metrics.recordSmallCount('FolderShortcut.Count', list.length);
+
var permutation = this.calculatePermitation_(this.array_, list);
this.array_ = list;
this.firePermutedEvent_(permutation);
@@ -160,6 +163,7 @@ FolderShortcutsDataModel.prototype = {
this.firePermutedEvent_(
this.calculatePermitation_(oldArray, this.array_));
this.save_();
+ metrics.recordUserAction('FolderShortcut.Add');
return addedIndex;
},
@@ -180,10 +184,12 @@ FolderShortcutsDataModel.prototype = {
}
}
+
mtomasz 2013/08/09 07:50:47 nit: Remove this empty line.
yoshiki 2013/08/09 08:41:44 Done.
if (removedIndex != -1) {
this.firePermutedEvent_(
this.calculatePermitation_(oldArray, this.array_));
this.save_();
+ metrics.recordUserAction('FolderShortcut.Remove');
return removedIndex;
}
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/navigation_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698