Replaced strerror() calls with threadsafe strerror_r()

runtime/bin/process_android.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_ANDROID)
 
 #include "bin/process.h"
 
 #include <errno.h>  // NOLINT
@@ skipping 249 matching lines @@
 
 
 dart::Mutex* ExitCodeHandler::mutex_ = new dart::Mutex();
 bool ExitCodeHandler::initialized_ = false;
 int ExitCodeHandler::sig_chld_fds_[2] = { 0, 0 };
 bool ExitCodeHandler::thread_terminated_ = false;
 dart::Monitor* ExitCodeHandler::thread_terminate_monitor_ = new dart::Monitor();
 
 
 static void SetChildOsErrorMessage(char** os_error_message) {
-  *os_error_message = strdup(strerror(errno));
+  const int kBufferSize = 1024;
+  char error_message[kBufferSize];
+  strerror_r(errno, error_message, kBufferSize);
+  *os_error_message = strdup(error_message);
 }
 
 
 static void SigChldHandler(int process_signal, siginfo_t* siginfo, void* tmp) {
   // Save errno so it can be restored at the end.
   int entry_errno = errno;
   // Signal the exit code handler where the actual processing takes
   // place.
   ssize_t result =
       TEMP_FAILURE_RETRY(write(ExitCodeHandler::WakeUpFd(), "", 1));
   if (result < 1) {
     perror("Failed to write to wake-up fd in SIGCHLD handler");
   }
   // Restore errno.
   errno = entry_errno;
 }
 
 
 static void ReportChildError(int exec_control_fd) {
   // In the case of failure in the child process write the errno and
   // the OS error message to the exec control pipe and exit.
   int child_errno = errno;
-  char* os_error_message = strerror(errno);
+  const int kBufferSize = 1024;
+  char os_error_message[kBufferSize];
+  strerror_r(errno, os_error_message, kBufferSize);
   ASSERT(sizeof(child_errno) == sizeof(errno));
   int bytes_written =
       FDUtils::WriteToBlocking(
           exec_control_fd, &child_errno, sizeof(child_errno));
   if (bytes_written == sizeof(child_errno)) {
     FDUtils::WriteToBlocking(
         exec_control_fd, os_error_message, strlen(os_error_message) + 1);
   }
   TEMP_FAILURE_RETRY(close(exec_control_fd));
   exit(1);
@@ skipping 274 matching lines @@
 
 
 intptr_t Process::CurrentProcessId() {
   return static_cast<intptr_t>(getpid());
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_ANDROID)