Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2263383002: PPC/s390: [turbofan] Add Float32(Max|Min) machine operators. (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Add Float32(Max|Min) machine operators. Port 2027b0bed15e89583b31a8ea1a53cb85cccffda2 Original commit message: The new operators are implemented similar to the Float64(Max|Min) which already exist. The purpose of the new operators is the implementation of the F32Max and F32Min instructions in WebAssembly. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/ad82a40509c5b5b4680d4299c8f08d6c6d31af3c Cr-Commit-Position: refs/heads/master@{#38803}

Patch Set 1 #

Patch Set 2 : fixed formating warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -90 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 2 chunks +185 lines, -90 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-22 19:47:06 UTC) #1
john.yan
lgtm
4 years, 4 months ago (2016-08-22 19:47:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263383002/1
4 years, 4 months ago (2016-08-22 19:49:53 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22310)
4 years, 4 months ago (2016-08-22 19:53:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263383002/20001
4 years, 4 months ago (2016-08-22 20:09:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 20:32:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 20:33:21 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad82a40509c5b5b4680d4299c8f08d6c6d31af3c
Cr-Commit-Position: refs/heads/master@{#38803}

Powered by Google App Engine
This is Rietveld 408576698