Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: src/gpu/GrClipStackClip.cpp

Issue 2263373002: check for wide-open inside quickContains (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkClipStack.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrClipStackClip.cpp
diff --git a/src/gpu/GrClipStackClip.cpp b/src/gpu/GrClipStackClip.cpp
index 695eda981fa379456995dd0ae1f2e22c678b38e0..7138f4b68a1d42bf6211b2a9f1dd36adf556a494 100644
--- a/src/gpu/GrClipStackClip.cpp
+++ b/src/gpu/GrClipStackClip.cpp
@@ -26,7 +26,7 @@ typedef GrReducedClip::ElementList ElementList;
static const int kMaxAnalyticElements = 4;
bool GrClipStackClip::quickContains(const SkRect& rect) const {
- if (!fStack) {
+ if (!fStack || fStack->isWideOpen()) {
bsalomon 2016/08/22 19:47:56 We don't need this call to isWideOpen() anymore, r
reed1 2016/08/22 19:49:49 Well, this is why my first version didn't put the
return true;
}
return fStack->quickContains(rect.makeOffset(SkIntToScalar(fOrigin.x()),
@@ -34,7 +34,7 @@ bool GrClipStackClip::quickContains(const SkRect& rect) const {
}
bool GrClipStackClip::quickContains(const SkRRect& rrect) const {
- if (!fStack) {
+ if (!fStack || fStack->isWideOpen()) {
bsalomon 2016/08/22 19:47:56 or this one.
return true;
}
return fStack->quickContains(rrect.makeOffset(SkIntToScalar(fOrigin.fX),
« no previous file with comments | « src/core/SkClipStack.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698