Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2263363002: [api] Add documentation for SetHandler(). (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@DocMove
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add documentation for SetHandler(). BUG=v8:5260 Committed: https://crrev.com/6cfa92fb45b4f808495b8ed17db34c7e87fa2cf8 Cr-Commit-Position: refs/heads/master@{#38831}

Patch Set 1 #

Patch Set 2 : Fix linebreak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M include/v8.h View 1 2 chunks +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Franzi
Hi Jochen, the SetHandler() functions didn't have any documentation. PTAL. Thanks, Franzi
4 years, 4 months ago (2016-08-23 07:54:39 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 12:44:24 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2262313002 Patch 20001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-23 12:47:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263363002/20001
4 years, 4 months ago (2016-08-23 14:15:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 14:41:33 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:41:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6cfa92fb45b4f808495b8ed17db34c7e87fa2cf8
Cr-Commit-Position: refs/heads/master@{#38831}

Powered by Google App Engine
This is Rietveld 408576698