Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 22633005: Make reflectClass(dynamic) throw an illegal argument exception. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/mirrors/mirrors.dart
diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart
index c22d3c3164e8d1bf673cbfbec46c8386c4810492..66b9abd17fa96455018a66e0abedcacfeb6332e4 100644
--- a/sdk/lib/mirrors/mirrors.dart
+++ b/sdk/lib/mirrors/mirrors.dart
@@ -135,7 +135,8 @@ external InstanceMirror reflect(Object reflectee);
* This function returns a [ClassMirror] reflecting *C*.
*
* If [key] is not an instance of [Type] then this function
- * throws an [ArgumentError].
+ * throws an [ArgumentError]. If [key] is the Type dynamic,
+ * throws an [ArgumentError] because dynamic is not a class.
*
* Note that since one cannot obtain a [Type] object from
* another isolate, this function can only be used to
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698