Make reflectClass(dynamic) throw an illegal argument exception.

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/object_store.h"
@@ skipping 169 matching lines @@
       return call_function.raw();
     }
     lookup_cls = lookup_cls.SuperClass();
   } while (!lookup_cls.IsNull());
   return Function::null();
 }
 
 static RawInstance* CreateClassMirror(const Class& cls,
                                       const AbstractType& type,
                                       const Instance& owner_mirror) {
+  ASSERT(!cls.IsDynamicClass() && !cls.IsVoidClass());
+
   if (cls.IsSignatureClass()) {
     if (cls.IsCanonicalSignatureClass()) {
       // We represent function types as canonical signature classes.
       return CreateFunctionTypeMirror(cls, type);
     } else {
       // We represent typedefs as non-canonical signature classes.
       return CreateTypedefMirror(cls, owner_mirror);
     }
   }
 
@@ skipping 98 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Mirrors_makeLocalMirrorSystem, 0) {
   return CreateMirrorSystem();
 }
 
 
 DEFINE_NATIVE_ENTRY(Mirrors_makeLocalClassMirror, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Type, type, arguments->NativeArgAt(0));
   const Class& cls = Class::Handle(type.type_class());
   ASSERT(!cls.IsNull());
+  if (cls.IsDynamicClass() || cls.IsVoidClass()) {
+    const Array& args = Array::Handle(Array::New(1));
+    args.SetAt(0, type);
+    Exceptions::ThrowByType(Exceptions::kArgument, args);
+    UNREACHABLE();
+  }
   // Strip the type for generics only.
   if (cls.NumTypeParameters() == 0) {
     return CreateClassMirror(cls,
                              type,
                              Object::null_instance());
   } else {
     return CreateClassMirror(cls,
                              AbstractType::Handle(),
                              Object::null_instance());
   }
@@ skipping 236 matching lines @@
   const GrowableObjectArray& member_mirrors =
       GrowableObjectArray::Handle(GrowableObjectArray::New());
 
   Object& entry = Object::Handle();
   DictionaryIterator entries(library);
 
   while (entries.HasNext()) {
     entry = entries.GetNext();
     if (entry.IsClass()) {
       const Class& klass = Class::Cast(entry);
-      if (!klass.IsCanonicalSignatureClass()) {
-        // The various implementations of public classes don't always have the
-        // expected superinterfaces or other properties, so we filter them out.
-        if (!RawObject::IsImplementationClassId(klass.id())) {
-          member_mirror = CreateClassMirror(klass,
-                                            AbstractType::Handle(),
-                                            owner_mirror);
-          member_mirrors.Add(member_mirror);
-        }
+      // We filter out implementation classes like Smi, Mint, Bignum,
+      // OneByteString; function signature classes; and dynamic.
+      if (!klass.IsCanonicalSignatureClass() &&
+          !klass.IsDynamicClass() &&
+          !RawObject::IsImplementationClassId(klass.id())) {
+        member_mirror = CreateClassMirror(klass,
+                                          AbstractType::Handle(),
+                                          owner_mirror);
+        member_mirrors.Add(member_mirror);
       }
     } else if (entry.IsField()) {
       const Field& field = Field::Cast(entry);
       member_mirror = CreateVariableMirror(field, owner_mirror);
       member_mirrors.Add(member_mirror);
     } else if (entry.IsFunction()) {
       const Function& func = Function::Cast(entry);
       if (func.kind() == RawFunction::kRegularFunction ||
           func.kind() == RawFunction::kGetterFunction ||
           func.kind() == RawFunction::kSetterFunction) {
@@ skipping 718 matching lines @@
 }
 
 
 DEFINE_NATIVE_ENTRY(VariableMirror_type, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(MirrorReference, ref, arguments->NativeArgAt(0));
   const Field& field = Field::Handle(ref.GetFieldReferent());
   return field.type();
 }
 
 }  // namespace dart