Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2263283002: Revert of Moving SkBlurImageFilter into core (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
vjiaoblack, f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Moving SkBlurImageFilter into core (patchset #6 id:100001 of https://codereview.chromium.org/2255803003/ ) Reason for revert: It looks like this breaks our roll into Google3: https://test.corp.google.com/ui#id=OCL:130943857:BASE:130944046:1471881622765:61dbdd3 Original issue's description: > Moving SkBlurImageFilter into core > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255803003 > > Committed: https://skia.googlesource.com/skia/+/dd3259eb95c3b47e11eefa3b176365a112a32b48 TBR=reed@google.com,fmalita@chromium.org,vjiaoblack@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ec417257b5866b653af1af6ef5e91388cc40f49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+720 lines, -735 lines) Patch
M gyp/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M gyp/effects.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +29 lines, -3 lines 0 comments Download
D src/core/SkBlurImageFilter.cpp View 1 chunk +0 lines, -295 lines 0 comments Download
D src/core/SkGpuBlurUtils.h View 1 chunk +0 lines, -46 lines 0 comments Download
D src/core/SkGpuBlurUtils.cpp View 1 chunk +0 lines, -382 lines 0 comments Download
A src/effects/SkBlurImageFilter.cpp View 1 chunk +259 lines, -0 lines 0 comments Download
A src/effects/SkGpuBlurUtils.h View 1 chunk +46 lines, -0 lines 0 comments Download
A src/effects/SkGpuBlurUtils.cpp View 1 chunk +382 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Moving SkBlurImageFilter into core
4 years, 4 months ago (2016-08-22 16:25:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263283002/1
4 years, 4 months ago (2016-08-22 16:25:53 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 16:26:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ec417257b5866b653af1af6ef5e91388cc40f49

Powered by Google App Engine
This is Rietveld 408576698