Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2263273003: [turbofan] Improve fast case of JSInstanceOf lowering. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve fast case of JSInstanceOf lowering. For O instanceof C, we only need to check the instance type while iterating the prototypes of O instead of checking both the instance type and the access check bit of the map. This is because we have the explicit range of "special object types", which include both JSProxy as well as the global object and proxy and all API objects that might have access checks or interceptors. Also restructure the loop exits somewhat to ensure that the branch cloning gets a chance to actually eliminate the bit materialization for the results. R=jarin@chromium.org Committed: https://crrev.com/b5629a108c1a95d923f4e42b2d5a61fb944a00fa Cr-Commit-Position: refs/heads/master@{#38860}

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE #

Patch Set 3 : Renaming based on comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -141 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 2 chunks +103 lines, -115 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +1 line, -26 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-22 20:51:52 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some small improvement for instanceof, helps EarleyBoyer quite a bit. Please take ...
4 years, 3 months ago (2016-08-23 07:01:43 UTC) #6
Benedikt Meurer
Hey Enrico, Jaro is overloaded with bugs/reviews. Please take a look. Thanks, Benedikt
4 years, 3 months ago (2016-08-24 08:41:51 UTC) #10
epertoso
lgtm https://codereview.chromium.org/2263273003/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/2263273003/diff/1/src/compiler/js-typed-lowering.cc#newcode1221 src/compiler/js-typed-lowering.cc:1221: Node* vtrue1; nit: I think that putting the ...
4 years, 3 months ago (2016-08-24 09:02:46 UTC) #11
Benedikt Meurer
https://codereview.chromium.org/2263273003/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/2263273003/diff/1/src/compiler/js-typed-lowering.cc#newcode1221 src/compiler/js-typed-lowering.cc:1221: Node* vtrue1; That wouldn't work because we need the ...
4 years, 3 months ago (2016-08-24 09:04:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263273003/1
4 years, 3 months ago (2016-08-24 09:04:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263273003/40001
4 years, 3 months ago (2016-08-24 09:15:17 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-24 09:38:40 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 09:38:53 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b5629a108c1a95d923f4e42b2d5a61fb944a00fa
Cr-Commit-Position: refs/heads/master@{#38860}

Powered by Google App Engine
This is Rietveld 408576698